Skip to content

BindValidationFailureAnalyzer uses wrong target #40035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

BindValidationFailureAnalyzer uses wrong target #40035

wants to merge 1 commit into from
+7 −5

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Mar 20, 2024

This PR fixes target in BindValidationFailureAnalyzer.getBindValidationExceptionDetails() as it seems to be using BindException accidentally.

For example, the following output is included in #39234 (comment).

Binding to target org.springframework.boot.context.properties.bind.BindException: Failed to bind properties under 'client' to com.example.demo.ClientProperties failed:

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 20, 2024
@philwebb philwebb added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 15, 2024
@philwebb philwebb added this to the 3.1.x milestone Apr 15, 2024
@mhalbritter mhalbritter changed the title Fix target in BindValidationFailureAnalyzer BindValidationFailureAnalyzer uses wrong target Apr 16, 2024
@mhalbritter mhalbritter mentioned this pull request Apr 16, 2024
Closed
mhalbritter pushed a commit that referenced this pull request Apr 16, 2024
@izeye @mhalbritter
Fix target in BindValidationFailureAnalyzer
201885a 
See gh-40035
@mhalbritter
Copy link
Contributor

Thanks!

@mhalbritter mhalbritter modified the milestones: 3.1.x, 3.1.11 Apr 16, 2024
@izeye izeye deleted the target branch April 16, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
3.1.11
Development

Successfully merging this pull request may close these issues.
4 participants
@izeye @mhalbritter @philwebb @spring-projects-issues