AnsiOutput.detectIfAnsiCapable broken on JDK22 #40172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: bug
facewise
force-pushed
the
fix-broken-ansi-detection-jdk22
branch
from
b0fe851 to
e56a0f3
Compare
facewise
force-pushed
the
fix-broken-ansi-detection-jdk22
branch
from
e56a0f3 to
f365476
Compare
scottfrederick
changed the title
mhalbritter
pushed a commit
that referenced
this pull request
May 2, 2024
mhalbritter
added a commit
that referenced
this pull request
May 2, 2024
|
Thank you very much and congratulations on your first contribution 🎉! |
|
@mhalbritter did you try this suggestion rather than adding the new smoke test? |
|
Oh sorry, I missed that. Let me investigate. |
mhalbritter
added a commit
that referenced
this pull request
May 2, 2024
|
@wilkinsona Indeed that worked :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix a method
detectIfAnsiCapableinAnsiOutputusing reflection invokingConsole.isTerminal()which is newly added on JDK22.As mentioned in #40160, starting JDK 22,
System.console()never returnsnull.Instead,
Console.isTerminal()is provided so we can use it to detect if the console is a terminal.Since Spring Boot still has to built on Java 17, check for the existence of
Console.isTerminal()is added and invokes only if it exists.Related Issue
#40160