-
Notifications
You must be signed in to change notification settings - Fork 41.1k
Add support for multiple StructuredLoggingJsonMembersCustomizers #43368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logging.structured.json.customizer
accept multiple Customizers also
Should |
…also See spring-projects#43312 (comment) Signed-off-by: Yanming Zhou <[email protected]>
philwebb
pushed a commit
that referenced
this pull request
Jan 24, 2025
Update `StructuredLoggingJsonProperties` and related class so that multiple `StructuredLoggingJsonMembersCustomizer` classes can be used. Signed-off-by: Yanming Zhou <[email protected]> See gh-43368
philwebb
added a commit
that referenced
this pull request
Jan 24, 2025
Thanks @quaff, I've kept both the |
arefbehboudi
pushed a commit
to arefbehboudi/spring-boot
that referenced
this pull request
Jan 29, 2025
Update `StructuredLoggingJsonProperties` and related class so that multiple `StructuredLoggingJsonMembersCustomizer` classes can be used. Signed-off-by: Yanming Zhou <[email protected]> See spring-projectsgh-43368 Signed-off-by: arefbehboudi <[email protected]>
arefbehboudi
pushed a commit
to arefbehboudi/spring-boot
that referenced
this pull request
Jan 29, 2025
…ers' See spring-projectsgh-43368 Signed-off-by: arefbehboudi <[email protected]>
Reopening because we discussed this today and we're going to keep just the singular |
philwebb
added a commit
that referenced
this pull request
Jan 29, 2025
Update `StructuredLoggingJsonProperties` no that only a single `customizer` property is supported. See gh-43368
philwebb
added a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #43312 (comment)