Skip to content

Add support for multiple StructuredLoggingJsonMembersCustomizers #43368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Dec 4, 2024

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 4, 2024
@philwebb philwebb changed the title Let logging.structured.json.customizer accept multiple Customizers also Let 'logging.structured.json.customizer' accept multiple Customizers Dec 4, 2024
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 4, 2024
@philwebb philwebb added this to the 3.5.x milestone Dec 4, 2024
@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Jan 13, 2025
@quaff
Copy link
Contributor Author

quaff commented Jan 15, 2025

Should logging.structured.json.customizer be deprecated and renamed to logging.structured.json.customizers?

@philwebb philwebb self-assigned this Jan 22, 2025
@philwebb philwebb changed the title Let 'logging.structured.json.customizer' accept multiple Customizers Add support for multiple StructuredLoggingJsonMembersCustomizers Jan 24, 2025
philwebb pushed a commit that referenced this pull request Jan 24, 2025
Update `StructuredLoggingJsonProperties` and related class so that
multiple `StructuredLoggingJsonMembersCustomizer` classes can be
used.

Signed-off-by: Yanming Zhou <[email protected]>

See gh-43368
@philwebb philwebb closed this in 311e440 Jan 24, 2025
@philwebb philwebb modified the milestones: 3.5.x, 3.5.0-M2 Jan 24, 2025
@philwebb
Copy link
Member

Thanks @quaff, I've kept both the customizer and customizers properties so that folks can pick the one that reads best for their situation.

@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label Jan 24, 2025
@wilkinsona wilkinsona added the for: team-meeting An issue we'd like to discuss as a team to make progress label Jan 25, 2025
arefbehboudi pushed a commit to arefbehboudi/spring-boot that referenced this pull request Jan 29, 2025
Update `StructuredLoggingJsonProperties` and related class so that
multiple `StructuredLoggingJsonMembersCustomizer` classes can be
used.

Signed-off-by: Yanming Zhou <[email protected]>

See spring-projectsgh-43368

Signed-off-by: arefbehboudi <[email protected]>
arefbehboudi pushed a commit to arefbehboudi/spring-boot that referenced this pull request Jan 29, 2025
@philwebb philwebb reopened this Jan 29, 2025
@philwebb
Copy link
Member

philwebb commented Jan 29, 2025

Reopening because we discussed this today and we're going to keep just the singular customizer property but we'll accept a list. I'll take care of that today.

@bclozel bclozel removed the for: team-meeting An issue we'd like to discuss as a team to make progress label Jan 29, 2025
philwebb added a commit that referenced this pull request Jan 29, 2025
Update `StructuredLoggingJsonProperties` no that only a single
`customizer` property is supported.

See gh-43368
@philwebb philwebb closed this Jan 29, 2025
philwebb added a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants