Skip to content

Correct the location of MyApplication.java in "Developing Your First Spring Boot Application" #43965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Ru311
Copy link
Contributor

@Ru311 Ru311 commented Jan 26, 2025

Corrected the file path to create the java project from src/main/java/MyApplication.java
to src/main/java/com/example/MyApplication.java

Corrected the file path to create the java project from 
src/main/java/MyApplication.java
src/main/java/com/example/MyApplication.java

Signed-off-by: Rucha Vaikar <[email protected]>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 26, 2025
@mhalbritter
Copy link
Contributor

Hello,

thanks for the PR. However, for #43964 there's more to be done. Besides changing the path (which this PR does) we also need to include a package com.example statement in the example code.

@mhalbritter mhalbritter added the status: waiting-for-feedback We need additional information before we can continue label Jan 27, 2025
@wilkinsona
Copy link
Member

I think we should merge this as a step in the right direction. We can then investigate the problem with the chomping support separately. It may well require a change in the Asciidoctor extensions project.

@wilkinsona wilkinsona changed the title #43964 Developing Your First Spring Boot Application section asks the user to create the application in the root package Correct the location of MyApplication.java in "Developing Your First Spring Boot Application" Jan 27, 2025
@mhalbritter mhalbritter added type: documentation A documentation update and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Jan 27, 2025
@mhalbritter mhalbritter added this to the 3.3.x milestone Jan 27, 2025
@mhalbritter mhalbritter self-assigned this Jan 27, 2025
mhalbritter pushed a commit that referenced this pull request Jan 27, 2025
@mhalbritter
Copy link
Contributor

Thanks @Ru311 !

@mhalbritter mhalbritter modified the milestones: 3.3.x, 3.3.9 Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants