Add configuration properties for JdbcTemplate's ignoreWarnings, skipResultsProcess, skipUndeclaredResults, and resultsMapCaseInsensitive #44470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ignore-warnings - skip-results-processing - skip-undeclared-results - results-map-case-insensitive Fix spring-projectsGH-44419 Signed-off-by: Yanming Zhou <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
|
Flagging for team attention to make sure everyone else is happy with the separate property approach. |
wilkinsona
added
the
for: team-attention
|
Read #44419 (comment) and I agree (unfortunately) that four properties are better. |
wilkinsona
changed the title
wilkinsona
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Mar 7, 2025
This commit adds configuration properties for additional settings of the auto-configured JdbcTemplate: * ignore-warnings * skip-results-processing * skip-undeclared-results * results-map-case-insensitive See gh-44470 Signed-off-by: Yanming Zhou <[email protected]>
snicoll
added a commit
that referenced
this pull request
Mar 7, 2025
|
@quaff since you're a prolific contributor, can you please review the polish commit. We use standard patterns for configuration properties, when in doubt please look at other classes. |
|
I'm confused about the order of fields, it's lexicographic ordered, but not exactly. |
|
It matches the order in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GH-44419