DATACMNS-1097 - Move classes to better matching packages. #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved/copied ExampleMatcherAccessor to data.util Copied StringMatcher to data.util Both were under repository, although they aren't really repository related and used independently from repositories. The new StringMatcher got an additional element to mimic Part.Type which it is going to replace in SD MongoDb. Added Degraph based test in order to avoid future dependency violations. Related ticket: DATACMNS-1721.
odrotbohm
pushed a commit
that referenced
this pull request
Jul 6, 2017
Introduced new ExampleMatcherAccessor in data.support in favor of the now deprecated one in data.repository.core to avoid a dependency into the repositories subsystem to work with examples in general. Added Degraph based test in order to avoid future cyclic package dependency violations. Original pull request: #230. Related ticket: DATAMONGO-1721.
odrotbohm
pushed a commit
that referenced
this pull request
Jul 6, 2017
Introduced new ExampleMatcherAccessor in data.support in favor of the now deprecated one in data.repository.core to avoid a dependency into the repositories subsystem to work with examples in general. Added Degraph based test in order to avoid future cyclic package dependency violations. Original pull request: #230. Related ticket: DATAMONGO-1721.
Aloren
pushed a commit
to Aloren/spring-data-commons
that referenced
this pull request
Jun 20, 2019
…s#232) * Show better message for missing config keystore props * Removes unused ExpectedException Fixes spring-projects#230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved/copied ExampleMatcherAccessor to data.util
Copied StringMatcher to data.util
Both were under repository, although they aren't really repository related and used independently from repositories.
The new StringMatcher got an additional element to mimic {{Part.Type}} which it is going to replace in SD MongoDb.
Added Degraph based test in order to avoid future dependency violations.
Related ticket: DATACMNS-1721.
Jira issue: https://jira.spring.io/browse/DATACMNS-1097