Add searchAfter interfaces to NativeSearchQueryBuilder #2106
Conversation
- support searchAfter for nativeSearchQuery
spring-projects-issues
added
the
status: waiting-for-triage
There was a problem hiding this comment.
We should not use the SearchAfterIntegrationTests to test this change. The change is on the NativeSearchQueryBuilder and should be tested there. I know there is no test for this builder, but this might be a good opportunity to create it and just test that the searchAfter values are set on the Query after building it.
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.stream.Collectors; | ||
| import java.util.stream.IntStream; | ||
|
|
||
| import org.elasticsearch.search.sort.SortBuilders; | ||
| import org.elasticsearch.search.sort.SortOrder; |
There was a problem hiding this comment.
This pulls in dependencies to Elasticsearch classes in this test, this test is independent of the used query type.
owen-q
force-pushed
the
support-searchafter
branch
from
5b82f64 to
8f395c9
Compare
- add validate conditions in searchAfter() - cause SearchAfterBuilder.setSortValues() assert not allow empty values - delete not appropriate tests for searchAfter in SearchAfterIntegrationTests
owen-q
force-pushed
the
support-searchafter
branch
from
8f395c9 to
a7129e9
Compare
@sothawo |
| @@ -342,6 +344,15 @@ public NativeSearchQueryBuilder withSuggestBuilder(SuggestBuilder suggestBuilder | |||
| return this; | |||
| } | |||
|
|
|||
| public NativeSearchQueryBuilder withSearchAfter(List<Object> searchAfter) { | |||
| if (searchAfter != null && searchAfter.isEmpty()) { | |||
There was a problem hiding this comment.
since SearchAfterBuilder not allow empty collections (it throws illegalArgument exception)
i add this conditions for ignore empty collections
closes #2105