Skip to content

pageable sort by property #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

pageable sort by property #381

wants to merge 1 commit into from

Conversation

NiklasLoechte
Copy link

@NiklasLoechte NiklasLoechte commented Apr 17, 2023 •
edited
Loading

  • this PR is adding sort by property abbility with pagable, mensioned in 379
  • supports first given sort param with direction

@pivotal-cla
Copy link

@NiklasLoechte Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@NiklasLoechte Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 17, 2023
@NiklasLoechte NiklasLoechte marked this pull request as ready for review April 18, 2023 06:46
schauder pushed a commit that referenced this pull request Apr 18, 2023
@NiklasLoechte @schauder
Pagination now supports sorting by property.
e71b170 
Closes #379
Original Pull Request #381
schauder added a commit that referenced this pull request Apr 18, 2023
@schauder
Polishing.
1e4cb6e 
Support ordering by more than a single property.
Fixed formatting.
Added `@uthor` annotations.

See #379
Original Pull Request #381
@schauder
Copy link
Contributor

Thanks, I merged that and also migrated the changes over to Spring Data JPA where the current versions of Spring Data Envers live now.

@schauder schauder closed this Apr 18, 2023
@schauder schauder self-assigned this Apr 18, 2023
@schauder schauder added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 18, 2023
gregturn pushed a commit to spring-projects/spring-data-jpa that referenced this pull request Apr 18, 2023
@schauder @gregturn
Pagination now supports sorting by property.
1bcdbc2 
Closes spring-projects/spring-data-envers#379
Original Pull Request spring-projects/spring-data-envers#381
trayanus1026 pushed a commit to trayanus1026/spring-data-jpa-java that referenced this pull request Aug 5, 2023
Pagination now supports sorting by property.
7af0e51 
Closes spring-projects/spring-data-envers#379
Original Pull Request spring-projects/spring-data-envers#381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@schauder schauder

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NiklasLoechte @pivotal-cla @schauder @spring-projects-issues