CrudRepository.deleteAll not working

[ggreen]

The CrudRepository.deleteAll() method is not removing all records.

Sample

    @Repository
    public interface AccountGeodeRepository extends CrudRepository<Account,String>  {

        Iterable<Account> findByName(String name);

        Iterable<Account> findByNameLike(String name);

    }

@ClientCacheApplication
@EnableEntityDefinedRegions
@EnableSecurity
public class GeodeConfig {
}

Controller

@AllArgsConstructor
@RestController
@RequestMapping("geode/accounts")
public class AccountGeodeController {

    private final AccountGeodeRepository repository;

    @DeleteMapping("deleteAll")
    public void deleteAll() {
        repository.deleteAll();
    }
}
....

[jxblum]

FYI, when filing SDG issues, please follow the required Issue ticket anatomy.

[jxblum]

It appears your Spring application is a ClientCache application given the declaration of the @ClientCacheApplication annotation on the application GeodeConfig class.

In addition, it appears you are using client PROXY Regions given the declaration of the @EnableEntityDefinedRegions annotation, also declared on the GeodeConfig class, using the provided defaults (e.g. clientRegionShortcut, which defaults to ClientRegionShortcut.PROXY).

At 1 time, the default implementation of the CrudRepository.deleteAll() method, provided by SDG's SimpleGemfireRepository.deleteAll() method, used to be implemented with Region.clear().

As the Javadoc for Region.clear() states, the method throws an UnsupportedOperationException for PARTITION Regions (PR), at least until GEODE-788 is implemented and resolved.

Given the limitation with the PR clear() operation in Apache Geode itself, since SGF-357, SDG has implemented CrudRepository.deleteAll() with Region.removeAll(keys), see here, then here.

However, this implementation currently fails to take into account that the Region.removeAll(keys) operation maybe invoked from a client PROXY Region, which has no keys, ever.

What is technically required, specifically in the client-side PROXY Region case, is...

region.removeAll(region.keySetOnServer())

Without breaking the applications that are server-side.

This Issue is only a problem for PARTITION Regions on the server-side. Both LOCAL and REPLICATE server-side Regions function correctly.

[jxblum]

I will be back porting this fix to SDG Pascal / 2.5, Ockham / 2.4 and Neumann / 2.3.