Skip to content

Invalid JoinType in QueryByExamplePredicateBuilder when using MatchMode ANY #3763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ArnaudLec opened this issue Feb 5, 2025 · 3 comments
Closed

Invalid JoinType in QueryByExamplePredicateBuilder when using MatchMode ANY #3763

ArnaudLec opened this issue Feb 5, 2025 · 3 comments
Assignees
@christophstrobl
Labels
type: bug A general bug
Milestone
3.4.4 (2024.1.4)

Comments

@ArnaudLec
Copy link
Contributor

Hi,

I stumbled upon a bug when using Example to find objects when matching with both a primitive attribute and an association at the same time when using MatchMode.ANY.

The join should be a left join when using MatchMode.ANY and only an inner join when using MatchMode.ALL.

Here is a reproducer :
https://github.com/ArnaudLec/query-by-example-join-match-any-bug
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 5, 2025
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 10, 2025
@christophstrobl
Copy link
Member

Thank you for reporting the issue und providing the sample. we'll look into it.

@christophstrobl
Copy link
Member

@ArnaudLec do you want to contribute a fix, since you already crafted one in the example project, and open a PR?

@christophstrobl christophstrobl added the status: waiting-for-feedback We need additional information before we can continue label Feb 26, 2025
@ArnaudLec ArnaudLec mentioned this issue Feb 28, 2025
Closed
4 tasks
@mp911de mp911de added this to the 3.4.4 (2024.1.4) milestone Mar 3, 2025
@spring-projects-issues
Copy link

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@spring-projects-issues spring-projects-issues added the status: feedback-reminder We've sent a reminder that we need additional information before we can continue label Mar 5, 2025
@christophstrobl christophstrobl removed status: waiting-for-feedback We need additional information before we can continue status: feedback-reminder We've sent a reminder that we need additional information before we can continue labels Mar 5, 2025
christophstrobl pushed a commit that referenced this issue Mar 6, 2025
@ArnaudLec @christophstrobl
Consider MatchMode when joining associations for QueryByExample.
99840c9 
This commit makes sure to use different join types depending on the actual match mode.

Closes: #3763
Original Pull Request: #3794

Signed-off-by: ArnaudLec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophstrobl christophstrobl

Labels
type: bug A general bug
Projects
None yet
Milestone
3.4.4 (2024.1.4)
Development

Successfully merging a pull request may close this issue.

Fix JoinType on associations when using MatchMode.ANY ArnaudLec/spring-data-jpa
4 participants
@mp911de @christophstrobl @spring-projects-issues @ArnaudLec