DATAJPA-1182 - Validate method parameters on query construction. #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
force-pushed
the
issue/DATAJPA-1182
branch
from
8bdc7b9 to
8049d03
Compare
For “In” and “NotIn” queries not providing a collection like argument results in an IllegalStateException at initialisation time. Conversely providing a collection as argument for a query other than “In” or “NotIn” also throws such an exception.
schauder
force-pushed
the
issue/DATAJPA-1182
branch
from
8049d03 to
69b3f25
Compare
added 2 commits
March 20, 2019 09:15
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * http://maven.apache.org/xsd/maven-4.0.0.xsd with 1 occurrences migrated to: https://maven.apache.org/xsd/maven-4.0.0.xsd ([https](https://maven.apache.org/xsd/maven-4.0.0.xsd) result 200). * http://projects.spring.io/spring-data-jpa with 1 occurrences migrated to: https://projects.spring.io/spring-data-jpa ([https](https://projects.spring.io/spring-data-jpa) result 301). # Ignored These URLs were intentionally ignored. * http://maven.apache.org/POM/4.0.0 with 2 occurrences * http://www.w3.org/2001/XMLSchema-instance with 1 occurrences Original pull request: #324
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * [ ] http://www.apache.org/licenses/ with 1 occurrences migrated to: https://www.apache.org/licenses/ ([https](https://www.apache.org/licenses/) result 200). * [ ] http://www.apache.org/licenses/LICENSE-2.0 with 347 occurrences migrated to: https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0) result 200). Original Pull Request: #357
|
See Jira for review comments https://jira.spring.io/browse/DATAJPA-1182 |
mp911de
pushed a commit
that referenced
this pull request
May 27, 2019
For “In” and “NotIn” queries not providing a collection like argument results in an IllegalStateException at initialisation time. Conversely providing a collection as argument for a query other than “In” or “NotIn” also throws such an exception. Original pull request: #228.
mp911de
added a commit
that referenced
this pull request
May 27, 2019
Reduce loop nesting. Tweak exception message wording. Simplify tests. Original pull request: #228.
|
That's merged and polished now. |
stsypanov
pushed a commit
to stsypanov/spring-data-jpa
that referenced
this pull request
Dec 13, 2019
For “In” and “NotIn” queries not providing a collection like argument results in an IllegalStateException at initialisation time. Conversely providing a collection as argument for a query other than “In” or “NotIn” also throws such an exception. Original pull request: spring-projects#228.
stsypanov
pushed a commit
to stsypanov/spring-data-jpa
that referenced
this pull request
Dec 13, 2019
Reduce loop nesting. Tweak exception message wording. Simplify tests. Original pull request: spring-projects#228.
|
Hi Guys, |
|
@ahaczewski create an issue in Jira: https://jira.spring.io/projects/DATAJPA |
|
Thanks @schauder, reported as https://jira.spring.io/browse/DATAJPA-1682, hope it is enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For “In” and “NotIn” queries not providing a collection like argument results in an IllegalStateException at initialization time.
Conversely providing a collection as an argument for a query other than “In” or “NotIn” also throws such an exception.