Skip to content

Migrate from Slf4J to JCL. #2360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Migrate from Slf4J to JCL. #2360

wants to merge 3 commits into from

Conversation

schauder
Copy link
Contributor

Closes #2359

@schauder schauder requested a review from gregturn November 17, 2021 13:15
mp911de
mp911de reviewed Dec 13, 2021
View reviewed changes
Copy link
Member

@mp911de mp911de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few places should be guarded with isDebugEnabled

@schauder
Copy link
Contributor Author

I made the requested changes and merged the PR.

@schauder schauder closed this Dec 15, 2021
@schauder schauder deleted the issue/2359-spring-jcl branch December 15, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de mp911de left review comments

@gregturn gregturn Awaiting requested review from gregturn

Assignees

@gregturn gregturn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate off SLF4J to Spring JCL
3 participants
@schauder @mp911de @gregturn