Skip to content

Fix NullPointer when deriving a count query for non-SELECT statements, delay count query derivation #2817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix NullPointer when deriving a count query for non-SELECT statements, delay count query derivation #2817

wants to merge 3 commits into from

Conversation

mp911de
Copy link
Member

@mp911de mp911de commented Feb 23, 2023

Should be backported to 2.7.x and 3.0.x as well.

@mp911de
Prepare issue branch.
e6f13e6
@mp911de
Delay count query derivation.
3c57259 
We now delay the count query creation to the actual time when we need the count query to avoid query creation of invalid queries (e.g. count queries for DELETE or UPDATE statements).

See #2812
@mp911de
Fix NullPointer when deriving a count query for non-SELECT statements.
ece6b21 
Closes #2812
@mp911de mp911de added the type: regression A regression from a previous release label Feb 23, 2023
@mp911de mp911de added this to the 2.7.9 (2021.2.9) milestone Feb 23, 2023
@mp911de mp911de linked an issue Feb 23, 2023 that may be closed by this pull request
NullPointerException in version 3.0.2 when using modifying native queries or SELECT queries that Spring Data cannot parse #2812
Closed
@mp911de mp911de requested a review from gregturn February 23, 2023 14:57
gregturn
gregturn approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@gregturn gregturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

This was referenced Feb 23, 2023
Closed
Closed
@gregturn gregturn closed this Feb 23, 2023
@gregturn gregturn deleted the issue/2812 branch February 23, 2023 18:01
@gregturn
Copy link
Contributor

Fixed in main and backported to 3.0.x and 2.7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregturn gregturn gregturn approved these changes

Assignees

@gregturn gregturn

Labels
type: regression A regression from a previous release
Projects
None yet
Milestone
2.7.9 (2021.2.9)
2 participants
@mp911de @gregturn