DATAJPA-1497 Allow to add a special parameter type from a Spring Data JPA extension #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reda-alaoui
force-pushed
the
DATAJPA-1497
branch
from
897ec5e to
dc19e52
Compare
reda-alaoui
force-pushed
the
DATAJPA-1497
branch
from
dc19e52 to
4448f34
Compare
|
Hello? |
|
At the very lest this needs some test, demonstrating how to use it. |
reda-alaoui
force-pushed
the
DATAJPA-1497
branch
3 times, most recently
from
eb367e5 to
6effa3b
Compare
|
@schauder , the test you requested has been added. |
reda-alaoui
force-pushed
the
DATAJPA-1497
branch
from
6effa3b to
9c96b65
Compare
|
Ping :) |
1 similar comment
|
Ping :) |
|
See my comment on the jira ticket: https://jira.spring.io/browse/DATAJPA-1497 |
schauder
pushed a commit
that referenced
this pull request
Jan 13, 2020
…ta JPA extension. This change allows to add a special parameter type by overriding org.springframework.data.jpa.repository.query.JpaParameters.JpaParameter.isBindable(). A "special parameter type" is a type of parameter that does not get bound to the query via the normal mechanism but gets some special treatment like `Class` or `Pageable`). Original pull request: #305.
schauder
added a commit
that referenced
this pull request
Jan 13, 2020
Improved naming and formatting. Made the `QueryExtractor` an argument of the `JpaQueryMethodFactory` constructor instead of its method. Original pull request: #305.
|
Thanks for your work. |
schauder
added a commit
that referenced
this pull request
Jan 14, 2020
Moved JpaQueryMethodFactory creation into a separate class. Removed http URL in copyright statement. Simplified bean injection of JpaQueryMethodFactory.build Originial pull request: #305. Signed-off-by: Jens Schauder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to add a special parameter type by overriding org.springframework.data.jpa.repository.query.JpaParameters.JpaParameter.isBindable()