Skip to content

Signed numeric literals should not have spaces after the sign. #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Signed numeric literals should not have spaces after the sign. #3343

wants to merge 1 commit into from

Conversation

hgwr
Copy link
Contributor

@hgwr hgwr commented Jan 31, 2024

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Related issues

#3342

@pivotal-cla
Copy link

@hgwr Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@hgwr Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 31, 2024
@hgwr hgwr mentioned this pull request Jan 31, 2024
Closed
christophstrobl pushed a commit that referenced this pull request Feb 1, 2024
@hgwr @christophstrobl
Fix hql rendering for signed numeric literals.
786024b 
This commit fixes an issue where an extra space is added between the sign and the actual value of signed numerics.

Closes: #3342
Original Pull Request: #3343
christophstrobl added a commit that referenced this pull request Feb 1, 2024
@christophstrobl
Polishing
a1ebea0 
Add issue reference to test and provide additional test cases.

Original Pull Request: #3343
christophstrobl pushed a commit that referenced this pull request Feb 1, 2024
@hgwr @christophstrobl
Fix hql rendering for signed numeric literals.
6f8f63a 
This commit fixes an issue where an extra space is added between the sign and the actual value of signed numerics.

Closes: #3342
Original Pull Request: #3343
christophstrobl added a commit that referenced this pull request Feb 1, 2024
@christophstrobl
Polishing
a364c4a 
Add issue reference to test and provide additional test cases.

Original Pull Request: #3343
christophstrobl pushed a commit that referenced this pull request Feb 1, 2024
@hgwr @christophstrobl
Fix hql rendering for signed numeric literals.
4447a53 
This commit fixes an issue where an extra space is added between the sign and the actual value of signed numerics.

Closes: #3342
Original Pull Request: #3343
christophstrobl added a commit that referenced this pull request Feb 1, 2024
@christophstrobl
Polishing
10a738c 
Add issue reference to test and provide additional test cases.

Original Pull Request: #3343
@christophstrobl
Copy link
Member

thank you @hgwr - merged to main development line and back ported to maintenance branches.

@hgwr hgwr deleted the fix-query-with-signed-numeric-literal branch February 1, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hgwr @pivotal-cla @christophstrobl @spring-projects-issues