Issue/3460 #3463
Closed
Issue/3460 #3463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that it can be used when extracting them from the result set. This fixes issue 3460.
|
@thjanssen Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@thjanssen Thank you for signing the Contributor License Agreement! |
| @@ -87,7 +88,7 @@ private List<ProcedureParameter> getParametersWithCompletedNames(List<ProcedureP | |||
|
|
|||
| private ProcedureParameter getParameterWithCompletedName(ProcedureParameter parameter, int i) { | |||
|
|
|||
| return new ProcedureParameter(completeOutputParameterName(i, parameter.getName()), parameter.getMode(), | |||
| return new ProcedureParameter(completeOutputParameterName(i, parameter.getName()), i+1, parameter.getMode(), | |||
There was a problem hiding this comment.
looks like we could reuse parameter.getPosition() here instead of i+1.
There was a problem hiding this comment.
Yes, that should be better. I've added the change to this PR
|
When this is fixed, do you think you could backport it to version 3.2.x? |
|
I intend to back port the fix if things work out as expected. |
|
Thank you @thjanssen - merged to main development line and back ported to 3.2.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix handling of position INOUT parameters when extracting output parameters (issue 3460)
Added position information to
ProcedureParameterclass, set it inStoredProcedureAttributeSource.extractOutputParametersFrom(...), and use that position inStoredProcedureJpaQuery.extractOutputParameterValueto get the result value.This change is based on the assumption that
NamedStoredProcedureQuery.parameters()returns the parameters in the correct order. As far as I understand the rest of the code, it already makes this assumption when using positional parameters.