Skip to content

JedisConnectionFactory.setDatabase(…) javadoc deprecation refers to client name #2831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pmverma opened this issue Jan 13, 2024 · 0 comments
Closed

JedisConnectionFactory.setDatabase(…) javadoc deprecation refers to client name #2831

pmverma opened this issue Jan 13, 2024 · 0 comments
Labels
type: documentation A documentation update
Milestone
3.1.9 (2023.0.9)

Comments

@pmverma
Copy link

pmverma commented Jan 13, 2024

I need to set the database index programmatically.
I came across the following method where the Javadoc needs to be updated.

https://github.com/spring-projects/spring-data-redis/blob/main/src/main/java/org/springframework/data/redis/connection/jedis/JedisConnectionFactory.java#L497-L500
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 13, 2024
@mp911de mp911de added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 18, 2024
@mp911de mp911de changed the title Update confusing deprecation comment or remove annotation JedisConnectionFactory.setDatabase(…) javadoc deprecation refers to client name Jan 18, 2024
@mp911de mp911de added this to the 3.1.9 (2023.0.9) milestone Jan 18, 2024
mp911de added a commit that referenced this issue Jan 18, 2024
@mp911de
Update deprecation description of `JedisConnectionFactory.setDatabase…
6a1d7f8 
…(…)`.

Mention database index instead of client name.

Closes #2831
mp911de added a commit that referenced this issue Jan 18, 2024
@mp911de
Update deprecation description of `JedisConnectionFactory.setDatabase…
ef48433 
…(…)`.

Mention database index instead of client name.

Closes #2831
mp911de added a commit that referenced this issue Jan 18, 2024
@mp911de
Deprecate LettuceConnectionFactory.setDatabase(…) in alignment with…
eff1e01 
… `JedisConnectionFactory.setDatabase(…)`

See #2831
mp911de added a commit that referenced this issue Jan 18, 2024
@mp911de
Polishing.
5dcdc84 
Reformat code.

See #2831
mp911de added a commit that referenced this issue Jan 18, 2024
@mp911de
Deprecate LettuceConnectionFactory.setDatabase(…) in alignment with…
75e51f5 
… `JedisConnectionFactory.setDatabase(…)`

See #2831
mp911de added a commit that referenced this issue Jan 18, 2024
@mp911de
Polishing.
25a6981 
Reformat code.

See #2831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: documentation A documentation update
Projects
None yet
Milestone
3.1.9 (2023.0.9)
Development

No branches or pull requests
3 participants
@mp911de @pmverma @spring-projects-issues