Skip to content

Methods in JdbcEntityOperations take Domainclasses that are (possibly) superfluous. [DATAJDBC-143] #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Oct 25, 2017 · 0 comments
Closed

Methods in JdbcEntityOperations take Domainclasses that are (possibly) superfluous. [DATAJDBC-143] #376

spring-projects-issues opened this issue Oct 25, 2017 · 0 comments
Assignees
@gregturn
Labels
type: enhancement A general enhancement
Milestone
1.0 RC1 (Lovelace)

Comments

@spring-projects-issues
Copy link

Jens Schauder opened DATAJDBC-143 and commented

either remove the parameters when they are superfluous or properly describe and possibly test a use case where they are required

Referenced from: pull request #69
@spring-projects-issues spring-projects-issues added the type: enhancement A general enhancement label Dec 31, 2020
mp911de added a commit that referenced this issue Feb 21, 2022
@mp911de @schauder
#373 - Use SpelQueryContext for expression query parsing.
687142e 
We now use SpelQueryContext and SpelExtractor for analysis and rewrite of queries using SpEL.

Original pull request: #376.
mp911de added a commit that referenced this issue Feb 21, 2022
@mp911de @schauder
#373 - Extract test into ExpressionQueryUnitTests.
9e11626 
Original pull request: #376.
mp911de pushed a commit that referenced this issue Feb 21, 2022
@schauder
#373 - Polishing.
06cc4e2 
Using soft assertions for more expressive test failures.

Original pull request: #376.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregturn gregturn

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
1.0 RC1 (Lovelace)
Development

No branches or pull requests
2 participants
@gregturn @spring-projects-issues