fix flaky tests in RelationalExampleMapperTests #1097
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
schauder
requested changes
Nov 24, 2021
There was a problem hiding this comment.
I didn't see any flakyness, although I tend to agree, that we shouldn't depend on the order of getDeclaredFields.
I don't like the duplication inherent in listing all the possible variants. We should instead split the string and ensure that the resulting set of conditions is the one we expect.
This was referenced Nov 24, 2021
…nsure the result set of conditions is the one we expect.
…onditions is the one we expect.
Hi, I've updated all PRs regarding flaky tests in the way that compare each part in the string instead of split the string and ensure that the resulting set of conditions is the one we expect. And all changes in #1096 and #1095 have been merged into this PR. Thanks for the advice! |
|
Thanks, that is polished and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
org.springframework.data.relational.repository.query.RelationalExampleMapperTests, the testsqueryByExampleEvenHandlesInvisibleFields(),queryByExampleSupportsPropertyTransforms(),queryByExampleWithFirstnameAndLastname(),queryByExampleWithFirstnameOrLastname(),queryByExampleWithNullMatchingFirstnameAndLastname()are all flaky due to the non-deterministic property ofgetDeclatedFields()(please refer document). it is internally invoked bygetMappedExample(). I fixed them by generating all possibilities of actual query strings and store them in aSet, then we only need to check if the actual query string is in theSet.