Skip to content

Unable to pass connection parameters to EmbeddedDatabaseBuilder [SPR-12614] #17215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Jan 10, 2015 · 2 comments
Closed

Unable to pass connection parameters to EmbeddedDatabaseBuilder [SPR-12614] #17215

spring-projects-issues opened this issue Jan 10, 2015 · 2 comments
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link
Collaborator

Petar Tahchiev opened SPR-12614 and commented

Following this problem here:
http://stackoverflow.com/questions/24687769/how-can-i-resolve-this-sqltransactionrollbackexception-with-hsqldb-in-spring-bat

I had a look at the EmbeddedDatabaseBuilder and it looks like it is always created with new EmbeddedDatabaseFactory(); (burried inside the constructor), so we can't change the EmbeddedDatabaseFactory being used. The factory, however does provide a setter method to set EmbeddedDatabaseConfigurer which would technically allow us to set additional connection properties (like hsqldb.tx=mvcc). I think the proper solution would be to add a setter method to EmbeddedDatabaseBuilder to allow setting custom DatabaseFactory.

No further details from SPR-12614
@spring-projects-issues spring-projects-issues added status: waiting-for-triage An issue we've not yet triaged or decided on type: enhancement A general enhancement and removed type: enhancement A general enhancement labels Jan 11, 2019
@rstoyanchev rstoyanchev added status: bulk-closed An outdated, unresolved issue that's closed in bulk as part of a cleaning process and removed status: waiting-for-triage An issue we've not yet triaged or decided on type: enhancement A general enhancement labels Jan 11, 2019
@spring-projects-issues
Copy link
Collaborator Author

Bulk closing outdated, unresolved issues. Please, reopen if still relevant.

snicoll pushed a commit that referenced this issue Aug 25, 2023
@chenqimiao @snicoll
Improve @Autowired method injection on mixed nullability args
32c0540 
See gh-17215
snicoll added a commit that referenced this issue Aug 25, 2023
@snicoll
Polish "Improve @Autowired method injection on mixed nullability args"
8efc7a9 
See gh-17215
snicoll added a commit that referenced this issue Aug 25, 2023
@snicoll
Merge pull request #17215 from chenqimiao
d0fc6dd 
* pr/24773:
  Polish "Improve @Autowired method injection on mixed nullability args"
  Improve @Autowired method injection on mixed nullability args

Closes gh-17215
@sbrannen sbrannen mentioned this issue Jan 4, 2024
Closed
@sbrannen
Copy link
Member

sbrannen commented Jan 4, 2024

@sbrannen sbrannen added in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement status: superseded An issue that has been superseded by another and removed status: bulk-closed An outdated, unresolved issue that's closed in bulk as part of a cleaning process labels Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sbrannen @rstoyanchev @spring-projects-issues