Skip to content

Stop overriding thread name prefix for externally configured Executor in ChannelRegistration #32132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Jan 26, 2024 · 0 comments
Closed

Stop overriding thread name prefix for externally configured Executor in ChannelRegistration #32132

snicoll opened this issue Jan 26, 2024 · 0 comments
Assignees
@snicoll
Labels
in: messaging Issues in messaging modules (jms, messaging) type: bug A general bug
Milestone
6.2.0-M1

Comments

@snicoll
Copy link
Member

snicoll commented Jan 26, 2024

AbstractMessageBrokerConfiguration uses ChannelRegistration to setup the following:

  • clientInboundChannel with a thread name prefix of clientInboundChannel-
  • clientOutboundChannel with a thread name prefix of clientOutboundChannel-
  • brokerChannel with a thread name prefix of brokerChannel-

It does so even if the underlying Executor has been externally provided. This is problematic, especially with virtual threads as the same instance is probably shared by all three channels.
@snicoll snicoll added in: messaging Issues in messaging modules (jms, messaging) type: bug A general bug labels Jan 26, 2024
@snicoll snicoll added this to the 6.2.0-M1 milestone Jan 26, 2024
@snicoll snicoll self-assigned this Jan 26, 2024
snicoll added a commit to snicoll/spring-framework that referenced this issue Jan 31, 2024
@snicoll
Stop setting a thread name prefix for externally defined Executors
6207bac 
This commit updates the WebSocket message broker configuration to stop
setting a thread name prefix for externally defined Executors.

This used to apply to:

* clientInboundChannel with a thread name prefix of
"clientInboundChannel-".
* clientOutboundChannel with a thread name prefix of
"clientOutboundChannel-".
* brokerChannel with a thread name prefix of "brokerChannel-".

Closes spring-projectsgh-32132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
in: messaging Issues in messaging modules (jms, messaging) type: bug A general bug
Projects
None yet
Milestone
6.2.0-M1
Development

No branches or pull requests
1 participant
@snicoll