Skip to content

Hoist concatenation of two constant Strings out of loops #24388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

stsypanov
Copy link
Contributor

In cases when concatenation arguments are the same they produce equal String at each iteration. This is why we can hoist them to reduce output of String garbage.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 17, 2020
@sbrannen sbrannen self-assigned this Jan 17, 2020
@sbrannen sbrannen added this to the 5.2.4 milestone Jan 17, 2020
@sbrannen sbrannen added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 17, 2020
@sbrannen sbrannen changed the title Hoist concatenation of two constants Strings out of loops Hoist concatenation of two constant Strings out of loops Jan 17, 2020
@sbrannen sbrannen merged commit 3adc7c3 into spring-projects:master Jan 17, 2020
@sbrannen
Copy link
Member

This has been merged into master.

Thanks

@stsypanov stsypanov deleted the hoist-string-concat branch February 25, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants