Skip to content

Merge source and substitution configuration in reference docs #25545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

diguage
Copy link
Contributor

@diguage diguage commented Aug 6, 2020

Asciidoctor User Manual: Applying Substitutions

image


I changed the code with sed script:

find . -name "*.adoc" -type f -print0 | xargs -0 gsed -i -f source.sed

source.sed:

:begin
/indent=0\]/,/\[subs="verbatim,quotes/ {
    /subs="verbatim,quotes/! {
        $! {
            N;
              b begin
        }
    }
    s/indent=0\]\n\[subs="verbatim,quotes/indent=0,subs="verbatim,quotes/;
}

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 6, 2020
@sbrannen
Copy link
Member

sbrannen commented Aug 6, 2020

Do the proposed changes fix any formatting issues in the generated documentation (HTML or PDF)? If so, which ones?

Or is the goal of this PR simply to merge the source and subs configuration lines?

@sbrannen sbrannen added status: waiting-for-feedback We need additional information before we can continue type: documentation A documentation task labels Aug 6, 2020
@diguage
Copy link
Contributor Author

diguage commented Aug 6, 2020

Do the proposed changes fix any formatting issues in the generated documentation (HTML or PDF)? If so, which ones?

Or is the goal of this PR simply to merge the source and subs configuration lines?

Sorry. I didn't compare them, I just improved them according to AsciiDoctor's syntax.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Aug 6, 2020
@sbrannen sbrannen changed the title format source block substitutions Merge source and substitution configuration in reference docs Aug 6, 2020
@sbrannen sbrannen removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 6, 2020
@sbrannen sbrannen added this to the 5.3 RC1 milestone Aug 6, 2020
@jhoeller jhoeller modified the milestones: 5.3 RC1, 5.3 RC2 Aug 24, 2020
@sbrannen sbrannen self-assigned this Sep 21, 2020
@sbrannen sbrannen modified the milestones: 5.3 RC2, 5.3 GA Sep 22, 2020
@sbrannen sbrannen removed the status: feedback-provided Feedback has been provided label Oct 26, 2020
@sbrannen sbrannen modified the milestones: 5.3 GA, 5.3.1 Oct 26, 2020
@jhoeller jhoeller modified the milestones: 5.3.1, 5.3.2 Nov 6, 2020
@sbrannen sbrannen modified the milestones: 5.3.2, 5.3.3 Dec 7, 2020
@sbrannen sbrannen closed this in eab61f6 Dec 28, 2020
@sbrannen
Copy link
Member

This has been merged into master in eab61f6.

Thanks

@sbrannen sbrannen added type: task A general task and removed type: documentation A documentation task labels Dec 28, 2020
@diguage diguage deleted the src-subs branch December 30, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants