Throw Exception when two primary beans are present in one factory #26612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the implementation of `DefaultListableBeanFactory.determinePrimaryCandidate()` did not throws `NoUniqueBeanDefinitionException` in the flowing two situations: * more than one primary bean in one ancestor factory * more than one local primary bean which implements `FactoryBean` This commit fix these issues by prefer primary bean in the youngest factory, and if the youngest factory has more than one primary bean thorws `NoUniqueBeanDefinitionException`.
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
the
in: core
sbrannen
changed the title
jhoeller
added
type: enhancement
|
We are likely to implement this is in a different fashion but the general point is valid: We ignore multiple matching primary beans in ancestors, just taking the first one, whereas we do insist on a unique primary bean to be available locally. We might simply add another |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the implementation of
DefaultListableBeanFactory.determinePrimaryCandidate()did not throwsNoUniqueBeanDefinitionExceptionin the flowing two situations:DefaultListableBeanFactoryTests.autowireBeanByTypeWithTwoPrimaryCandidatesInOneAncestor())FactoryBean.(test unit inDefaultListableBeanFactoryTests.autowireBeanByTypeWithTwoPrimaryFactoryBeans())This commit fix these issues by prefer primary bean in the youngest factory, and if the youngest factory has more than one primary bean thorws
NoUniqueBeanDefinitionException.