Skip to content

Introduce null-safe index operator in SpEL #29847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Introduce null-safe index operator in SpEL #29847

wants to merge 1 commit into from

Conversation

Trympyrym
Copy link
Contributor

@Trympyrym Trympyrym commented Jan 18, 2023 •
edited by sbrannen
Loading

Introduce SpEL support for syntax like collection?.[expr] for null-safe indexing into lists, arrays, maps, etc.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 18, 2023
@rstoyanchev rstoyanchev added the in: core Issues in core modules (aop, beans, core, context, expression) label Jan 24, 2023
@sbrannen sbrannen self-assigned this Jan 23, 2024
@sbrannen sbrannen added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 6, 2024
@sbrannen sbrannen added this to the 6.2.x milestone Feb 6, 2024
@sbrannen sbrannen changed the title SpEL: add support for null-safe get element from collection by index SpEL: introduce null-safe index operator Feb 6, 2024
@sbrannen sbrannen changed the title SpEL: introduce null-safe index operator Introduce null-safe index operator in SpEL Feb 6, 2024
@sbrannen sbrannen mentioned this pull request Feb 6, 2024
Closed
@sbrannen
Copy link
Member

sbrannen commented Feb 6, 2024 •
edited
Loading

Hi @Trympyrym,

Congratulations on submitting your first PR for the Spring Framework! 👍

Add to SpEL support for syntax like collection?.[expr] for null-safe get element from lists, arrays, maps, etc

We agree that we should introduce an operator for null-safe indexing; however, we are not yet convinced that ?. should be the syntax for this new operator since the . typically implies some form of property access or method invocation.

In any case, your PR is a great start, and we'll take it from here.

Thanks!

@sbrannen sbrannen modified the milestones: 6.2.x, 6.2.0-M1 Feb 6, 2024
@sbrannen sbrannen mentioned this pull request Feb 6, 2024
Closed
@sbrannen sbrannen mentioned this pull request Mar 1, 2024
Closed
@sbrannen
Copy link
Member

sbrannen commented Mar 8, 2024

Current work on this issue can be viewed in the following feature branch.

main...sbrannen:spring-framework:issues/gh-29847-null-safe-index-operator-in-SpEL

This was referenced Mar 8, 2024
Closed
Closed
@sbrannen sbrannen mentioned this pull request Mar 22, 2024
Closed
sbrannen pushed a commit to sbrannen/spring-framework that referenced this pull request Mar 23, 2024
@Trympyrym @sbrannen
Introduce null-safe index operator in SpEL
9f4d46f 
See spring-projectsgh-29847
sbrannen added a commit to sbrannen/spring-framework that referenced this pull request Mar 23, 2024
@sbrannen
Revise null-safe index operator support in SpEL
4d43317 
See spring-projectsgh-29847
sbrannen added a commit to sbrannen/spring-framework that referenced this pull request Mar 23, 2024
@sbrannen
Retain null-safe syntax in AST representation of SpEL indexers
d2bd0d5 
Prior to this commit, SpEL's CompoundExpression omitted the null-safe
syntax in AST string representations of indexing operations.

To address this, this commit implements isNullSafe() in Indexer.

See spring-projectsgh-29847
sbrannen added a commit to sbrannen/spring-framework that referenced this pull request Mar 23, 2024
@sbrannen
Support compilation of null-safe index operations in SpEL
f05cd52 
See spring-projectsgh-29847
sbrannen added a commit that referenced this pull request Mar 23, 2024
@sbrannen
Support compilation of null-safe index operations in SpEL
38c473f 
See gh-29847
sbrannen added a commit that referenced this pull request Mar 23, 2024
@sbrannen
Document null-safe index operator in SpEL
218a148 
See gh-29847
@sbrannen sbrannen closed this in 2a74fe5 Mar 23, 2024
@sbrannen
Copy link
Member

This has been merged into main in 9f4d46f and revised/extended in 4d43317, d2bd0d5, 38c473f, and 218a148.

Thanks again for kick-starting this effort! 👍

jgiovaresco added a commit to gravitee-io/gravitee-api-management that referenced this pull request Feb 14, 2025
@jgiovaresco
test: update exception message asserted due to Spring change
2d18049 
spring-projects/spring-framework#29847
jgiovaresco added a commit to gravitee-io/gravitee-api-management that referenced this pull request Feb 14, 2025
@jgiovaresco
test: update exception message asserted due to Spring change
26e119c 
spring-projects/spring-framework#29847
jgiovaresco added a commit to gravitee-io/gravitee-api-management that referenced this pull request Feb 17, 2025
@jgiovaresco
test: update exception message asserted due to Spring change
7b00da4 
spring-projects/spring-framework#29847
jgiovaresco added a commit to gravitee-io/gravitee-api-management that referenced this pull request Feb 17, 2025
@jgiovaresco
test: update exception message asserted due to Spring change
8d7bd2e 
spring-projects/spring-framework#29847
mergify bot pushed a commit to gravitee-io/gravitee-api-management that referenced this pull request Feb 20, 2025
@jgiovaresco @mergify
test: update exception message asserted due to Spring change
d4e252e 
spring-projects/spring-framework#29847
(cherry picked from commit 8d7bd2e)
jgiovaresco added a commit to gravitee-io/gravitee-api-management that referenced this pull request Feb 20, 2025
@jgiovaresco
test: update exception message asserted due to Spring change
76ffc73 
spring-projects/spring-framework#29847
(cherry picked from commit 8d7bd2e)
jgiovaresco added a commit to gravitee-io/gravitee-api-management that referenced this pull request Feb 28, 2025
@jgiovaresco
test: update exception message asserted due to Spring change
0491453 
spring-projects/spring-framework#29847
(cherry picked from commit 8d7bd2e)
jgiovaresco added a commit to gravitee-io/gravitee-api-management that referenced this pull request Feb 28, 2025
@jgiovaresco
test: update exception message asserted due to Spring change
cf44fde 
spring-projects/spring-framework#29847
(cherry picked from commit 8d7bd2e)
jgiovaresco added a commit to gravitee-io/gravitee-api-management that referenced this pull request Feb 28, 2025
@jgiovaresco
test: update exception message asserted due to Spring change
8fd39d0 
spring-projects/spring-framework#29847
(cherry picked from commit 8d7bd2e)
jgiovaresco added a commit to gravitee-io/gravitee-api-management that referenced this pull request Feb 28, 2025
@jgiovaresco
test: update exception message asserted due to Spring change
bae02c8 
spring-projects/spring-framework#29847
(cherry picked from commit 8d7bd2e)
jgiovaresco added a commit to gravitee-io/gravitee-api-management that referenced this pull request Feb 28, 2025
@jgiovaresco
test: update exception message asserted due to Spring change
86f4f60 
spring-projects/spring-framework#29847
(cherry picked from commit 8d7bd2e)
jgiovaresco added a commit to gravitee-io/gravitee-api-management that referenced this pull request Feb 28, 2025
@jgiovaresco
test: update exception message asserted due to Spring change
6ac3610 
spring-projects/spring-framework#29847
(cherry picked from commit 8d7bd2e)
jgiovaresco added a commit to gravitee-io/gravitee-api-management that referenced this pull request Feb 28, 2025
@jgiovaresco
test: update exception message asserted due to Spring change
dc0a55b 
spring-projects/spring-framework#29847
(cherry picked from commit 8d7bd2e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
6.2.0-M1
Development

Successfully merging this pull request may close these issues.
4 participants
@Trympyrym @sbrannen @rstoyanchev @spring-projects-issues