HTTP interface client should not have blockingTimeout set and leave it to the underlying client by default #30403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
in: web
rstoyanchev
changed the title
rstoyanchev
approved these changes
May 2, 2023
There was a problem hiding this comment.
Overall, looks good.
We just need to expand on the documentation a bit. It's not that we block without a timeout, but rather we defer to the underlying client, which is in a better position to provide more control over timeout, e.g. connecting vs request handling, etc. So the blockingTimeout at our level is a higher level convenience, but without any settings out of the box.
rstoyanchev
pushed a commit
that referenced
this pull request
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-30248.