Use UTF-8 by default for JSON multipart content in ContentRequestMatchers
#31924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@azdanov Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@azdanov Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
in: test
sbrannen
changed the title
ContentRequestMatchers for multipart data handling
rstoyanchev
requested changes
Jan 15, 2024
| fileUpload.setFileItemFactory(new DiskFileItemFactory()); | ||
| DiskFileItemFactory factory = new DiskFileItemFactory(); | ||
| factory.setDefaultCharset(DEFAULT_ENCODING); | ||
| fileUpload.setFileItemFactory(factory); |
There was a problem hiding this comment.
Switching the general default could break existing tests, and that should wait for a major or minor release. In the meantime, we could narrow the scope and default to UTF-8 specifically for JSON. That would be safer and addresses the original issue.
|
I agree, but I don't have time now. So feel free to add. |
rstoyanchev
added
type: enhancement
rstoyanchev
changed the title
ContentRequestMatchers for multipart data handlingContentRequestMatchers
|
Moving to 6.2 to avoid any regressions in a maintenance release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #31923
I've added default UTF-8 charset to be used in
DiskFileItemFactory.This should allow ContentRequestMatchers to correctly handle multipartData which contains unicode.