-
Notifications
You must be signed in to change notification settings - Fork 38.5k
Fix DefaultDataBuffer#getNativeBuffer()
to set correct limit
#32009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
injae-kim
wants to merge
1
commit into
spring-projects:main
from
injae-kim:fix-defaultDataBuffer-getNativeBuffer
+58
−2
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
spring-core/src/test/java/org/springframework/core/io/buffer/DefaultDataBufferTests.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/* | ||
* Copyright 2024-2024 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.core.io.buffer; | ||
|
||
import java.nio.ByteBuffer; | ||
import java.nio.charset.StandardCharsets; | ||
|
||
import org.junit.jupiter.api.Test; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
import static org.springframework.core.io.buffer.DataBufferUtils.release; | ||
|
||
/** | ||
* Tests for {@link DefaultDataBuffer}. | ||
* | ||
* @author Injae Kim | ||
* @since 6.2 | ||
*/ | ||
class DefaultDataBufferTests { | ||
|
||
private final DefaultDataBufferFactory bufferFactory = new DefaultDataBufferFactory(); | ||
|
||
@Test // gh-30967 | ||
void getNativeBuffer() { | ||
Comment on lines
+37
to
+38
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
DefaultDataBuffer buffer = bufferFactory.allocateBuffer(256); | ||
buffer.write("0123456789", StandardCharsets.UTF_8); | ||
|
||
byte[] result = new byte[7]; | ||
buffer.read(result); | ||
assertThat(result).isEqualTo("0123456".getBytes(StandardCharsets.UTF_8)); | ||
|
||
ByteBuffer nativeBuffer = buffer.getNativeBuffer(); | ||
assertThat(nativeBuffer.position()).isEqualTo(7); | ||
assertThat(buffer.readPosition()).isEqualTo(7); | ||
assertThat(nativeBuffer.limit()).isEqualTo(10); | ||
assertThat(buffer.writePosition()).isEqualTo(10); | ||
|
||
release(buffer); | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
readPosition: 7
andwritePosition: 10
,Current
getNativebuffer
return bytebuffer withlimit: 3
(readableByteCount(), writePos - readPos)But I think we should set
limit: 10
(writePos) correctly.Like this commit, maybe we set redableByteCount() as
length
on bytebuffer's limit by mistake 😅