Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Javadoc for substituteNamedParameters() in NamedParameterUtils regarding empty lists #32380

Closed
wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Mar 6, 2024

Document that an empty list is not guaranteed to be supported by the database – for example, MySQL and PostgreSQL don't support foo in ().

Document that empty list is guaranteed to be supported by the database, for example MySQL and PostgreSQL doesn't support `foo in ()`.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 6, 2024
@sbrannen sbrannen added in: data Issues in data modules (jdbc, orm, oxm, tx) type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 6, 2024
@sbrannen sbrannen self-assigned this Mar 6, 2024
@sbrannen sbrannen added this to the 6.2.0-M1 milestone Mar 6, 2024
@sbrannen sbrannen changed the title Polishing javadoc of NamedParameterUtils.substituteNamedParameters() Improve Javadoc for NamedParameterUtils.substituteNamedParameters() regarding empty lists Mar 6, 2024
@sbrannen sbrannen changed the title Improve Javadoc for NamedParameterUtils.substituteNamedParameters() regarding empty lists Improve Javadoc for substituteNamedParameters() in NamedParameterUtils regarding empty lists Mar 6, 2024
sbrannen pushed a commit that referenced this pull request Mar 6, 2024
This commit documents that an empty list is not guaranteed to be
supported by the database. For example, MySQL and PostgreSQL do not
support `foo in ()`.

See gh-32380
@sbrannen sbrannen closed this in 6461eec Mar 6, 2024
@sbrannen
Copy link
Member

sbrannen commented Mar 6, 2024

This has been merged into main in be136d7 and revised in 6461eec.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants