Skip to content

Include actual cause's message in various parsing exception messages #32636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Include actual cause's message in various parsing exception messages #32636

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58309f2
fix: Modify the exception type to NumberFormatException.
remeio Apr 14, 2024
663123c
fix: Modify the exception message.
remeio Apr 16, 2024
d934c47
fix: Use the message of original exception.
remeio Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rc/main/java/org/springframework/transaction/interceptor/DefaultTransactionAttribute.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ public void resolveAttributeStrings(@Nullable StringValueResolver resolver) {
}
catch (RuntimeException ex) {
throw new IllegalArgumentException(
"Invalid timeoutString value \"" + timeoutString + "\" - cannot parse into int");
"Invalid timeoutString value \"" + timeoutString + "\": " + ex);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use ; as a separator since : is already part of Throwable::toString

Suggested change
"Invalid timeoutString value \"" + timeoutString + "\": " + ex);
"Invalid timeoutString value \"" + timeoutString + "\"; " + ex);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will fix these cases together

}
}
}
Expand Down