Improve check to preserve case sensitivity of scheme if URI variable present #33715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RI variable See spring-projectsGH-33699, Continue c261ca3 ``` Map has no value for 'thescheme' java.lang.IllegalArgumentException: Map has no value for 'thescheme' at org.springframework.web.util.UriComponents$MapTemplateVariables.getValue(UriComponents.java:348) at org.springframework.web.util.UriComponents.expandUriComponent(UriComponents.java:263) at org.springframework.web.util.HierarchicalUriComponents.expandInternal(HierarchicalUriComponents.java:436) at org.springframework.web.util.HierarchicalUriComponents.expandInternal(HierarchicalUriComponents.java:53) at org.springframework.web.util.UriComponents.expand(UriComponents.java:161) at org.springframework.web.util.UriComponentsBuilder.buildAndExpand(UriComponentsBuilder.java:364) ```
|
cc @rstoyanchev |
|
Thanks for taking a look. I'm curious if you actually have a case with a scheme that is part literal and part variable? |
spring-projects-issues
added
the
status: waiting-for-triage
No, I found it by code review. |
rstoyanchev
approved these changes
Oct 16, 2024
rstoyanchev
added
in: web
rstoyanchev
changed the title
rstoyanchev
pushed a commit
that referenced
this pull request
Oct 16, 2024
See gh-33715 ``` Map has no value for 'thescheme' java.lang.IllegalArgumentException: Map has no value for 'thescheme' at org.springframework.web.util.UriComponents$MapTemplateVariables.getValue(UriComponents.java:348) at org.springframework.web.util.UriComponents.expandUriComponent(UriComponents.java:263) at org.springframework.web.util.HierarchicalUriComponents.expandInternal(HierarchicalUriComponents.java:436) at org.springframework.web.util.HierarchicalUriComponents.expandInternal(HierarchicalUriComponents.java:53) at org.springframework.web.util.UriComponents.expand(UriComponents.java:161) at org.springframework.web.util.UriComponentsBuilder.buildAndExpand(UriComponentsBuilder.java:364) ```
|
This is now merged. Please, note we don't change the author tag for a trivial change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See GH-33699, Continue c261ca3