Skip to content

Polish #33891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Polish #33891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spring-jdbc/src/test/java/org/springframework/jdbc/object/SqlQueryTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
*/
class SqlQueryTests {

//FIXME inline?
// FIXME inline?
private static final String SELECT_ID =
"select id from custmr";
private static final String SELECT_ID_WHERE =
Expand Down
2 changes: 1 addition & 1 deletion ...n/java/org/springframework/messaging/handler/invocation/reactive/ChannelSendOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ public final void onNext(T item) {
requiredWriteSubscriber().onNext(item);
return;
}
//FIXME revisit in case of reentrant sync deadlock
// FIXME revisit in case of reentrant sync deadlock
synchronized (this) {
if (this.state == State.READY_TO_WRITE) {
requiredWriteSubscriber().onNext(item);
Expand Down
10 changes: 5 additions & 5 deletions spring-web/src/jmh/java/org/springframework/http/support/HeadersAdapterBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ public static class BenchmarkData {
public MultiValueMap<String, String> headers;
public Function<MultiValueMap<String, String>, Set<Map.Entry<String, List<String>>>> entriesProvider;

//Uncomment the following line and comment the similar line for setupImplementationBaseline below
//to benchmark current implementations
// Uncomment the following line and comment the similar line for setupImplementationBaseline below
// to benchmark current implementations
@Setup(Level.Trial)
public void initImplementationNew() {
this.entriesProvider = map -> new HttpHeaders(map).headerSet();
Expand All @@ -85,16 +85,16 @@ public void initImplementationNew() {
case "HttpComponents" -> new HttpComponentsHeadersAdapter(new HttpGet("https://example.com"));
case "Netty5" -> new Netty5HeadersAdapter(io.netty5.handler.codec.http.headers.HttpHeaders.newHeaders());
case "Jetty" -> new JettyHeadersAdapter(HttpFields.build());
//FIXME tomcat/undertow implementations (in another package)
// FIXME tomcat/undertow implementations (in another package)
// case "Tomcat" -> new TomcatHeadersAdapter(new MimeHeaders());
// case "Undertow" -> new UndertowHeadersAdapter(new HeaderMap());
default -> throw new IllegalArgumentException("Unsupported implementation: " + this.implementation);
};
initHeaders();
}

//Uncomment the following line and comment the similar line for setupImplementationNew above
//to benchmark old implementations
// Uncomment the following line and comment the similar line for setupImplementationNew above
// to benchmark old implementations
// @Setup(Level.Trial)
public void setupImplementationBaseline() {
this.entriesProvider = MultiValueMap::entrySet;
Expand Down
2 changes: 1 addition & 1 deletion spring-web/src/main/java/org/springframework/http/server/reactive/ChannelSendOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public final void onNext(T item) {
requiredWriteSubscriber().onNext(item);
return;
}
//FIXME revisit in case of reentrant sync deadlock
// FIXME revisit in case of reentrant sync deadlock
synchronized (this) {
if (this.state == State.READY_TO_WRITE) {
requiredWriteSubscriber().onNext(item);
Expand Down