Y_Update PlaceholderParser.java #34021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i have solved the NestedPlaceholderPart does not recursively resolve placeholders spring-projects#34020 issue
|
@abdelmawla56 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
hello @vip-delete @spring-projects i have solved the issue please allow me to edit the file |
snicoll
requested changes
Dec 4, 2024
| @@ -443,34 +443,30 @@ record SimplePlaceholderPart(String text, String key, @Nullable String fallback) | |||
|
|
|||
| @Override | |||
| public String resolve(PartResolutionContext resolutionContext) { | |||
| String resolvedValue = resolveToText(resolutionContext, this.key); | |||
There was a problem hiding this comment.
Please revert all the formatting change as it makes it harder for us to see what you've changed.
snicoll
added
the
status: waiting-for-feedback
|
Looking at the code I am not sure what that meant to accomplish. If you want to contribute, please create a proper branch so that you can work in your IDE and add some tests. I've taken over, see #34020 |
snicoll
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i have solved the NestedPlaceholderPart does not recursively resolve placeholders #34020 issue