Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate rowsExpected property of SqlQuery for removal #34526

Closed
wants to merge 1 commit into from
Closed

Deprecate rowsExpected property of SqlQuery for removal #34526

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Mar 3, 2025

Fix GH-34512

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 3, 2025
@sbrannen sbrannen mentioned this pull request Mar 3, 2025
Closed
@sbrannen sbrannen changed the title Deprecate unused "rowsExpected" of SqlQuery for removal Deprecate rowsExpected property of SqlQuery for removal Mar 3, 2025
@sbrannen sbrannen self-assigned this Mar 3, 2025
@sbrannen sbrannen added in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 3, 2025
@sbrannen sbrannen added this to the 6.2.4 milestone Mar 3, 2025
@sbrannen sbrannen mentioned this pull request Mar 3, 2025
Closed
sbrannen
sbrannen approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested a few changes, since we plan to split the deprecation and removal across 6.2.4 and 7.0 (see #34530).

Though, there's no need to make the requested changes: I'll simply omit them when merging.

sbrannen pushed a commit that referenced this pull request Mar 3, 2025
@quaff @sbrannen
Deprecate unused "rowsExpected" property of SqlQuery for removal
78cc5df 
See gh-34526

Signed-off-by: Yanming Zhou <[email protected]>
@sbrannen sbrannen closed this in 30d793c Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrannen sbrannen sbrannen approved these changes

Assignees

@sbrannen sbrannen

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Projects
None yet
Milestone
6.2.4
Development

Successfully merging this pull request may close these issues.

Deprecate rowsExpected property of SqlQuery
3 participants
@quaff @sbrannen @spring-projects-issues