Recursively boxing Kotlin nested value classes in CoroutinesUtils
#34682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a follow-up to spring-projects#34592. It introduces recursive boxing of Kotlin nested value classes in CoroutinesUtils. Signed-off-by: Dmitry Sulman <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
sdeleuze
added
type: enhancement
sdeleuze
added
the
in: core
sdeleuze
pushed a commit
to sdeleuze/spring-framework
that referenced
this pull request
Mar 31, 2025
This commit is a follow-up to spring-projectsgh-34592. It introduces recursive boxing of Kotlin nested value classes in CoroutinesUtils. Signed-off-by: Dmitry Sulman <[email protected]> Closes spring-projectsgh-34682
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #34592.
Unfortunately #34592 does not fully resolve the original issue (#34458), as the invocation of suspended functions occurs in
CoroutinesUtilswhich was not addressed in that PR.While #33630 may eventually eliminate this logic duplication, it's still worthwhile to add recursive boxing to
CoroutinesUtilsin the meantime.