Skip to content

Fixed NPEs in AntPathMatcher #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixed NPEs in AntPathMatcher #943

wants to merge 1 commit into from

Conversation

rs017991
Copy link
Contributor

I noticed that the MVC Test redirectedUrl matcher fails with a NullPointerException if there happens to be no Redirected URL on the response (the test should still fail, but with a proper assertion error).

One way to fix this would be to assertNotNull in the respective MockMvcResultMatchers method before calling the AntPathMatcher, but I thought it would be more appropriate to fix the underlying null-safety issues. You may disagree.

@pivotal-issuemaster
Copy link

@rs017991 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@bclozel
Copy link
Member

bclozel commented Jul 20, 2016

Thank you for the PR! Could you please create an issue for this pull request in the Spring Framework issue tracker. When you do, please make sure to fill the Reference URL with the link to this PR. Thanks!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 24, 2019
@pivotal-issuemaster
Copy link

@rs017991 Thank you for signing the Contributor License Agreement!

@DeCaMil
Copy link

DeCaMil commented Jul 16, 2019

@rs017991 Could you change your added tests to not use underscore (_) in the method names?
Your PR is being marked as poor quality because of this.

@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) in: test Issues in the test module labels Jul 16, 2019
@sbrannen
Copy link
Member

@rs017991, since quite a bit of time has passed since you submitted this PR, would you mind reworking your contribution on top of master and force-pushing the changes?

@sbrannen sbrannen added the status: waiting-for-feedback We need additional information before we can continue label Jul 16, 2019
@rs017991
Copy link
Contributor Author

@sbrannen np

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jul 16, 2019
@rs017991 rs017991 mentioned this pull request Jul 16, 2019
Closed
@rs017991
Copy link
Contributor Author

@sbrannen I guess I deleted my fork at some point in the past few years, so I had to open a new PR: #23297

@rs017991 rs017991 closed this Jul 16, 2019
@sbrannen sbrannen added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 16, 2019
@sbrannen
Copy link
Member

@sbrannen I guess I deleted my fork at some point in the past few years, so I had to open a new PR: #23297

OK. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in: core Issues in core modules (aop, beans, core, context, expression) in: test Issues in the test module status: feedback-provided Feedback has been provided status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rs017991 @pivotal-issuemaster @bclozel @DeCaMil @sbrannen @rstoyanchev @spring-projects-issues