Skip to content

Add fallback type information to empty CollectionModels #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odrotbohm opened this issue Jul 29, 2021 · 0 comments
Closed

Add fallback type information to empty CollectionModels #1590

odrotbohm opened this issue Jul 29, 2021 · 0 comments
Assignees
@odrotbohm
Labels
in: core Core parts of the project type: enhancement
Milestone
1.4 M2

Comments

@odrotbohm
Copy link
Member

Empty CollectionModel instances are currently not processed by the RepresentationModelProcessorInvoker as it needs to inspect the element type to find all processors to invoke. We should allow users to add the element type information on CollectionModel explicitly to allow empty models to be processed, too.
@odrotbohm odrotbohm added type: enhancement in: core Core parts of the project labels Jul 29, 2021
@odrotbohm odrotbohm added this to the 1.4 M2 milestone Jul 29, 2021
@odrotbohm odrotbohm self-assigned this Jul 29, 2021
odrotbohm added a commit that referenced this issue Jul 29, 2021
@odrotbohm
#1590 - Polishing.
26f4655
odrotbohm added a commit that referenced this issue Jul 29, 2021
@odrotbohm
#1590 - Support for explicit type information on CollectionModel.
a1d2752 
We now allow explicit definition of a fallback collection element type on CollectionModel to be used in cases of an empty model, so that the RepresentationModelProcessor infrastructure can still reason about the element type and also invoke the processor for empty collection models.

Fixes #1590.
odrotbohm added a commit that referenced this issue Jul 29, 2021
@odrotbohm
#1590 - Polishing.
db885ba
@fdutton fdutton mentioned this issue Jan 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: core Core parts of the project type: enhancement
Projects
None yet
Milestone
1.4 M2
Development

No branches or pull requests
1 participant
@odrotbohm