Skip to content

Resolve deprecations in spring-integration-kafka after upgrade to Spring for Apache Kafka 2.8/30 #3661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
artembilan opened this issue Nov 3, 2021 · 3 comments · Fixed by #3751
Closed

Resolve deprecations in spring-integration-kafka after upgrade to Spring for Apache Kafka 2.8/30 #3661

artembilan opened this issue Nov 3, 2021 · 3 comments · Fixed by #3751
Assignees
@garyrussell
Labels
in: Kafka type: enhancement
Milestone
6.0 M2

Comments

@artembilan
Copy link
Member

No description provided.

@artembilan artembilan added this to the 6.0.x milestone Nov 3, 2021
@artembilan
Copy link
Member Author

Need also to figure out what to do with already deprecated org.springframework.kafka.listener.adapter.RetryingMessageListenerAdapter in the KafkaMessageDrivenChannelAdapter

@50qbits
Copy link

50qbits commented Mar 16, 2022

Hello, I've found that KafkaMessageListenerContainerSpec.errorHandler is using GenericErrorHandler and this is deprecated in favor of DefaultErrorHandler (since spring-kafka 2.8).

Besides spring-kafka ConcurrentKafkaListenerContainerFactory and KafkaMessageListenerContainer.setErrorHandler​(ErrorHandler errorHandler) is deprecated in favor of setCommonErrorHandler(CommonErrorHandler)

Any plans to updated this before 6.0.x?

@garyrussell
Copy link
Contributor

I have almost completed the PR. It should be posted today and will be in the next milestone.

@garyrussell garyrussell modified the milestones: 6.0.x, 6.0 M2 Mar 16, 2022
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Mar 16, 2022
@garyrussell
spring-projectsGH-3661: Resolve Spring Apache Kafka Deprecations
4d18ded 
Resolves spring-projects#3661
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Mar 16, 2022
@garyrussell
spring-projectsGH-3661: Resolve Spring Apache Kafka Deprecations
c579f37 
Resolves spring-projects#3661
@garyrussell garyrussell mentioned this issue Mar 16, 2022
Merged
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Mar 16, 2022
@garyrussell
spring-projectsGH-3661: Resolve Spring Apache Kafka Deprecations
42f43d5 
Resolves spring-projects#3661
artembilan pushed a commit that referenced this issue Mar 16, 2022
@garyrussell
GH-3661: Resolve Spring Apache Kafka Deprecations
0550380 
Resolves #3661

* Don't allow existing listener; remove unnecessary try/catch; add what's new.
* Fix link in whats-new.adoc
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Sep 21, 2022
@garyrussell
spring-projectsGH-3661: Fix Javadocs for RetryingMLA
20848a1 
Use of the `RetryingMessageListenerAdapter` was removed in
spring-projects@0550380
but the javadocs were not corrected.
artembilan pushed a commit that referenced this issue Sep 21, 2022
@garyrussell @artembilan
GH-3661: Fix Javadocs for RetryingMLA
cbfa150 
Use of the `RetryingMessageListenerAdapter` was removed in
0550380
but the javadocs were not corrected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
in: Kafka type: enhancement
Projects
None yet
Milestone
6.0 M2
Development

Successfully merging a pull request may close this issue.

GH-3661: Resolve Spring Apache Kafka Deprecations garyrussell/spring-integration
3 participants
@garyrussell @artembilan @50qbits