Skip to content

Kafka OB Gateway Wait For Assignment #3942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyrussell opened this issue Nov 14, 2022 · 0 comments · Fixed by #3943
Closed

Kafka OB Gateway Wait For Assignment #3942

garyrussell opened this issue Nov 14, 2022 · 0 comments · Fixed by #3943
Assignees
@garyrussell
Labels
in: Kafka type: bug
Milestone
6.0.0

Comments

@garyrussell
Copy link
Contributor

See spring-projects/spring-kafka#2318

Gateway should wait for assignment of partitions in reply container before sending request/reply messages.
@garyrussell garyrussell added this to the 6.0.0 milestone Nov 14, 2022
@garyrussell garyrussell self-assigned this Nov 14, 2022
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Nov 14, 2022
@garyrussell
spring-projectsGH-3942: Fix Race in Kafka OB Gateway
f07ce32 
Resolves spring-projects#3942

When determining the default reply-to topic/partition, we need to wait for assignment.

Already covered by `KafkaDslTests` (a recent build failure exposed this problem).

**No back-port - 5.5.x uses 2.7.x by default, which does not support this.**

5.5.x users can call `waitForAssignment` on the `ReplyingKafkaTemplate` that is
supplied to the gateways before sending messages.
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Nov 14, 2022
@garyrussell
spring-projectsGH-3942: Fix Race in Kafka OB Gateway
6c25026 
Resolves spring-projects#3942

When determining the default reply-to topic/partition, we need to wait for assignment.

Already covered by `KafkaDslTests` (a recent build failure exposed this problem).

**No back-port - 5.5.x uses 2.7.x by default, which does not support this.**

5.5.x users can call `waitForAssignment` on the `ReplyingKafkaTemplate` that is
supplied to the gateways before sending messages.
@garyrussell garyrussell mentioned this issue Nov 14, 2022
Merged
artembilan pushed a commit that referenced this issue Nov 15, 2022
@garyrussell @artembilan
GH-3942: Fix Race in Kafka OB Gateway
e19e6d4 
Resolves #3942

When determining the default reply-to topic/partition, we need to wait for assignment.

Already covered by `KafkaDslTests` (a recent build failure exposed this problem).

**No back-port - 5.5.x uses 2.7.x by default, which does not support this.**

5.5.x users can call `waitForAssignment` on the `ReplyingKafkaTemplate` that is
supplied to the gateways before sending messages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
in: Kafka type: bug
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

GH-3942: Fix Race in Kafka OB Gateway garyrussell/spring-integration
2 participants
@garyrussell @artembilan