Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Java configuration for Kafka Inbound Channel Adapter incorrect #8573

Closed
manderson23 opened this issue Mar 16, 2023 · 1 comment · Fixed by #8575
Closed

Documentation: Java configuration for Kafka Inbound Channel Adapter incorrect #8573

manderson23 opened this issue Mar 16, 2023 · 1 comment · Fixed by #8575
Labels
in: Kafka type: bug
Milestone
6.1.0-M2

Comments

@manderson23
Copy link

The Java example for configuring KafkaMessageSource uses constructors and methods that no longer exist to set topic, group ID and client ID.
@manderson23 manderson23 added status: waiting-for-triage The issue need to be evaluated and its future decided type: bug labels Mar 16, 2023
@manderson23 manderson23 changed the title Documentation: Java configuration for Kafka Inbound Channel Adapter incorrent Documentation: Java configuration for Kafka Inbound Channel Adapter incorrect Mar 16, 2023
@artembilan
Copy link
Member

Yes. All those samples are broken: https://docs.spring.io/spring-integration/docs/current/reference/html/kafka.html#kafka-inbound-pollable.
An XML one is OK from the config perspective, but it doesn't work because KafkaInboundChannelAdapterParser bug.

Thank you for reporting!

@artembilan artembilan added this to the 6.1.0-M2 milestone Mar 16, 2023
@artembilan artembilan removed the status: waiting-for-triage The issue need to be evaluated and its future decided label Mar 16, 2023
artembilan added a commit to artembilan/spring-integration that referenced this issue Mar 16, 2023
@artembilan
spring-projectsGH-8573: Fix KafkaMessageSource samples in docs
26d2d9c 
Fixes spring-projects#8573

* Also add a Kotlin DSL sample

**Cherry-pick to `6.0.x` & `5.5.x`**
@artembilan artembilan mentioned this issue Mar 16, 2023
Merged
garyrussell pushed a commit that referenced this issue Mar 20, 2023
@artembilan
GH-8573: Fix KafkaMessageSource samples in docs (#8575)
05f1fd8 
Fixes #8573

* Also add a Kotlin DSL sample

**Cherry-pick to `6.0.x` & `5.5.x`**
garyrussell pushed a commit that referenced this issue Mar 20, 2023
@artembilan @garyrussell
GH-8573: Fix KafkaMessageSource samples in docs (#8575)
61809c5 
Fixes #8573

* Also add a Kotlin DSL sample

**Cherry-pick to `6.0.x` & `5.5.x`**
garyrussell pushed a commit that referenced this issue Mar 20, 2023
@artembilan @garyrussell
GH-8573: Fix KafkaMessageSource samples in docs (#8575)
dfae1a2 
Fixes #8573

* Also add a Kotlin DSL sample

**Cherry-pick to `6.0.x` & `5.5.x`**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: Kafka type: bug
Projects
None yet
Milestone
6.1.0-M2
Development

Successfully merging a pull request may close this issue.

GH-8573: Fix KafkaMessageSource samples in docs artembilan/spring-integration
2 participants
@artembilan @manderson23