Enforce maxFetchSize = 1 on the AbstractFetchLimitingMessageSource from the StandardRotationPolicy when mode is fair
#8967
Labels
Milestone
Comments
artembilan
added a commit
that referenced
this issue
Feb 26, 2024
Fixes: #8967 In the `fair` mode the `StandardRotationPolicy` re-configures an `AbstractFetchLimitingMessageSource` for a new directory (and possible new `ConnectionFactory`) in the `beforeReceive()`. However, with default `maxFetchSize` (or bigger than `1`), the `receive()`` would poll `toBeReceived` internal queue for files cached from the previous polling cycle. Since we rotate the source immediately to a new set of options, all those cached files make no sense or even can cause the problem on fetching their content in case of `AbstractRemoteFileStreamingMessageSource` when we rotate to a new `ConnectionFactory`. * Call `fetchLimitingMessageSource.setMaxFetchSize(1);` in the `StandardRotationPolicy.beforeReceive()` when `fair && !this.initialized` **Auto-cherry-pick to `6.1.x`**
artembilan
added a commit
that referenced
this issue
Feb 26, 2024
Fixes: #8967 In the `fair` mode the `StandardRotationPolicy` re-configures an `AbstractFetchLimitingMessageSource` for a new directory (and possible new `ConnectionFactory`) in the `beforeReceive()`. However, with default `maxFetchSize` (or bigger than `1`), the `receive()`` would poll `toBeReceived` internal queue for files cached from the previous polling cycle. Since we rotate the source immediately to a new set of options, all those cached files don't make sense or even can cause the problem on fetching their content in case of `AbstractRemoteFileStreamingMessageSource` when we rotate to a new `ConnectionFactory`. * Call `fetchLimitingMessageSource.setMaxFetchSize(1);` in the `StandardRotationPolicy.beforeReceive()` when `fair && !this.initialized` (cherry picked from commit c78630e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
fairmode theStandardRotationPolicyre-configuresAbstractFetchLimitingMessageSourcefor a new directory (and possible newConnectionFactory) in thebeforeReceive().However with default
maxFetchSize(or bigger than1), thereceive()would polltoBeReceivedinternal queue for files cached from the previous polling cycle.Since we rotate the source immediately to a new set of options, all those cached files don't make sense or even can cause the problem on fetching their content in case of
AbstractRemoteFileStreamingMessageSourcewhen we rotate to a newConnectionFactory.See more info in the: #8898
The text was updated successfully, but these errors were encountered: