GH-3826: Fix SimplePool for resizing from MAX #3829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#3826 By default, the `SimplePool` is used with an `Integer.MAX_VALUE` pool size. There is a performance degradation in the `setPoolSize()` when we try to decrease the pool size: the `while` for `permits.tryAcquire()` is too long close to the current `Integer.MAX_VALUE` pool size * Revise the logic in the `setPoolSize()` to use `Semaphore.reducePermits()` instead of the loop. * Change the calculation for a new pool size for the current pool state: or it is a size of a new request, or iti s equal to the `inUse.size()`. It will be reduced on subsequent `releaseItem()` calls * Reduce the number of `available` according a new pool size based on the `inUse`. So, if `inUse > newPoolSize`, the `available` is cleared. Otherewise, it is reduced to the number which would give `newPoolSize` together with the `inUse` size **Cherry-pick to `5.5.x`**
|
here is some possible fix for the problem. Thanks /CC @garyrussell |
garyrussell
suggested changes
Jun 27, 2022
| @@ -266,6 +272,19 @@ public synchronized void close() { | |||
| removeAllIdleItems(); | |||
| } | |||
|
|
|||
| private static class PoolSemaphore extends Semaphore { | |||
|
|
|||
| public PoolSemaphore(int permits) { | |||
There was a problem hiding this comment.
Should be package protected (will solve checkstyle too).
There was a problem hiding this comment.
Yeah... Saw that. Trying to fix the main for latest SF compatibility...
Thank you if you are going to fix this!
|
Merged as 6fe59a7 and cherry-picked. |
| T item = this.available.poll(); | ||
| if (item != null) { | ||
| doRemoveItem(item); | ||
| } | ||
| this.poolSize.decrementAndGet(); | ||
| delta++; | ||
| else { |
There was a problem hiding this comment.
Guess this should help in the default init case we had
|
This has been merged as 6fe59a7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3826
By default, the
SimplePoolis used with anInteger.MAX_VALUEpool size.There is a performance degradation in the
setPoolSize()when we try todecrease the pool size: the
whileforpermits.tryAcquire()is too longclose to the current
Integer.MAX_VALUEpool sizesetPoolSize()to useSemaphore.reducePermits()instead of the loop.
or it is a size of a new request, or iti s equal to the
inUse.size().It will be reduced on subsequent
releaseItem()callsavailableaccording a new pool size based on theinUse.So, if
inUse > newPoolSize, theavailableis cleared.Otherewise, it is reduced to the number which would give
newPoolSizetogetherwith the
inUsesizeCherry-pick to
5.5.x