Some LockRegistryLeaderInitiator improvements
#8570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is better to not go to the target lock provider at all if the current thread is already interrupted. * Check for the `Thread.currentThread().isInterrupted()` in the `while` loop and `restartSelectorBecauseOfError()` immediately without checking for a lock * Fix some other simple typos in the `LockRegistryLeaderInitiator` **Cherry-pick to `6.0.x`**
|
Do not merge yet: looking into |
to revoke leader smoothly. Turns out just canceling the `Future` may lead to a broken lock where we cannot unlock it because the target lock repository may not work with interrupted threads. This way a new leader must wait until the lock is expired in the store
garyrussell
approved these changes
Mar 15, 2023
garyrussell
pushed a commit
that referenced
this pull request
Mar 15, 2023
* Some `LockRegistryLeaderInitiator` improvements It is better to not go to the target lock provider at all if the current thread is already interrupted. * Check for the `Thread.currentThread().isInterrupted()` in the `while` loop and `restartSelectorBecauseOfError()` immediately without checking for a lock * Fix some other simple typos in the `LockRegistryLeaderInitiator` **Cherry-pick to `6.0.x`** * * Introduce a `LeaderSelector.yielding` flag to revoke leader smoothly. Turns out just canceling the `Future` may lead to a broken lock where we cannot unlock it because the target lock repository may not work with interrupted threads. This way a new leader must wait until the lock is expired in the store
|
...and cherry-picked as 2adf334 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is better to not go to the target lock provider at all if the current thread is already interrupted.
Thread.currentThread().isInterrupted()in thewhileloop andrestartSelectorBecauseOfError()immediately without checking for a lockLockRegistryLeaderInitiatorCherry-pick to
6.0.x