Do not block by default #8580
Merged
Do not block by default #8580
+284
−340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, many timeouts in the project are like `-1` or other negative value with a meaning to wait indefinitely. According to distributed systems design and bad demo developing experience it is not OK to block forever. * Rework most of the timeouts in the framework to be `30` seconds. Only one remained as `1` seconds is a `PollingConsumer` where it is better to not block even for those 30 seconds when no messages in the queue, but let the polling task be rescheduled. * Remove the `MessagingGatewaySupport.replyTimeout` propagation down to the `PollingConsumer` correlator where it was a `-1` before and blocked the polling thread on the `Queue.poll()`. This fixed the problem with a single thread in a pool for auto-configured `TaskScheduler`. Now with 1 seconds wait time we are able to switch to other scheduled tasks even with only 1 thread in the pool
garyrussell
suggested changes
Mar 21, 2023
| Long timeout = requestTimeout.getValue(Long.class); | ||
| if (timeout != null) { | ||
| gateway.setRequestTimeout(timeout); | ||
| if (requestTimeout != null) { |
There was a problem hiding this comment.
We still need a null check here and use the default; GenericMessagingTemplate has -1 as its default.
There was a problem hiding this comment.
Sure! See MessagingGatewaySupport:
private long replyTimeout = IntegrationContextUtils.DEFAULT_TIMEOUT;
...
template.setReceiveTimeout(this.replyTimeout);
So, if we don't call setReplyTimeout(), then that default value is used in the GenericMessagingTemplate.
| if (requestTimeout == null || gatewayAnnotation.requestTimeout() != Long.MIN_VALUE) { | ||
| if (requestTimeout == null || | ||
| gatewayAnnotation.requestTimeout() != IntegrationContextUtils.DEFAULT_TIMEOUT) { | ||
|
|
||
| requestTimeout = new ValueExpression<>(gatewayAnnotation.requestTimeout()); | ||
| } |
There was a problem hiding this comment.
See comment in timeouts().
garyrussell
approved these changes
Mar 21, 2023
|
I addition some notes in the Migration Guide: https://github.com/spring-projects/spring-integration/wiki/Spring-Integration-6.0-to-6.1-Migration-Guide |
fmbenhassine
added a commit
to spring-projects/spring-batch
that referenced
this pull request
Jul 6, 2023
The default value of sendTimeout in MessagingTemplate was changed from -1 to 30000 in SI 6.1 Related to spring-projects/spring-integration#8580
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, many timeouts in the project are like
-1or other negative value with a meaning to wait indefinitely.According to distributed systems design and bad demo developing experience it is not OK to block forever.
30seconds. Only one remained as1seconds is aPollingConsumerwhere it is better to not block even for those 30 seconds when no messages in the queue, but let the polling task be rescheduled.MessagingGatewaySupport.replyTimeoutpropagation down to thePollingConsumercorrelator where it was a-1before and blocked the polling thread on theQueue.poll().This fixed the problem with a single thread in a pool for auto-configured
TaskScheduler. Now with 1 seconds wait time we are able to switch to other scheduled tasks even with only 1 thread in the pool