-
Notifications
You must be signed in to change notification settings - Fork 1.6k
DelegatingByTypeSerializer does not work for Tombstones #2154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone
Comments
Thanks for reporting; I've changed this to a bug.
|
garyrussell
added a commit
to garyrussell/spring-kafka
that referenced
this issue
Mar 8, 2022
Resolves spring-projects#2154 Check for null and return.
garyrussell
added a commit
to garyrussell/spring-kafka
that referenced
this issue
Mar 8, 2022
Resolves spring-projects#2154 Check for null and return. **cherry-pick to 2.8.x, 2.7.x (partial)**
garyrussell
added a commit
to garyrussell/spring-kafka
that referenced
this issue
Mar 8, 2022
Resolves spring-projects#2154 Check for null and return. **cherry-pick to 2.8.x, 2.7.x (partial)**
garyrussell
added a commit
to garyrussell/spring-kafka
that referenced
this issue
Mar 8, 2022
Resolves spring-projects#2154 Check for null and return. **cherry-pick to 2.8.x, 2.7.x (partial)**
This was referenced Mar 8, 2022
artembilan
pushed a commit
that referenced
this issue
Mar 8, 2022
Resolves #2154 Check for null and return. **cherry-pick to 2.8.x, 2.7.x (partial)**
artembilan
pushed a commit
that referenced
this issue
Mar 8, 2022
Resolves #2154 Check for null and return. **cherry-pick to 2.8.x, 2.7.x (partial)** # Conflicts: # spring-kafka/src/main/java/org/springframework/kafka/support/serializer/DelegatingByTypeSerializer.java
artembilan
pushed a commit
that referenced
this issue
Mar 8, 2022
Resolves #2154 Check for null and return. **cherry-pick to 2.8.x, 2.7.x (partial)** # Conflicts: # spring-kafka/src/main/java/org/springframework/kafka/support/serializer/DelegatingByTypeSerializer.java # Conflicts: # spring-kafka/src/main/java/org/springframework/kafka/support/serializer/DelegatingByTopicSerializer.java # spring-kafka/src/main/java/org/springframework/kafka/support/serializer/DelegatingByTypeSerializer.java # spring-kafka/src/main/java/org/springframework/kafka/support/serializer/DelegatingSerializer.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
DelegatingByTypeSerializer should not crash when receiving Tombstone (null value)
I should be able to configure a Serializer for Tombstones based on
KafkaNull
Current Behavior
DelegatingByTypeSerializer throws NullpointerException on Tombstone message due to
Context
I'm using tombstone messages to remove entries from compacted topics and trigger deletion in consumer services. When starting to use DelegatingByTypeSerializer producing the Tombstones lead to errors.
A possible fix could be:
The text was updated successfully, but these errors were encountered: