Skip to content

Replace getAnnotation to findAnnotation in MethodKafkaListenerEndpoint::getReplyTopic() #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
VovkaSOL opened this issue Jun 14, 2022 · 0 comments · Fixed by #2305
Closed

Replace getAnnotation to findAnnotation in MethodKafkaListenerEndpoint::getReplyTopic() #2304

VovkaSOL opened this issue Jun 14, 2022 · 0 comments · Fixed by #2305
Assignees
@garyrussell
Labels
backport 2.8.x (obsolete) backport 2.9.x (obsolete) type: enhancement
Milestone
3.0.0-M5

Comments

@VovkaSOL
Copy link

Expected Behavior

@sendto annotation must be scanned for method in abstract class

Current Behavior

@KafkaListener scanned in abstract class(because use AnnotationUtils.findAnnotation), but @sendto can't scanned (because use SendTo ann = AnnotationUtils.getAnnotation(replyingMethod, SendTo.class);)

Context
@garyrussell garyrussell added this to the 3.0.0.M5 milestone Jun 14, 2022
@garyrussell garyrussell self-assigned this Jun 14, 2022
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jun 14, 2022
@garyrussell
spring-projectsGH-2304: Fix SendTo on Interface Etc.
1528951 
Resolves spring-projects#2304

`@SendTo` was only detected on the concrete listener method.

Use `AnnotatedElementUtils.findMergedAnnotation()` instead.

**cherry-pick to 2.9.x, 2.8.x**
@garyrussell garyrussell mentioned this issue Jun 14, 2022
Merged
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jun 14, 2022
@garyrussell
spring-projectsGH-2304: Fix SendTo on Interface Etc.
b99096f 
Resolves spring-projects#2304

`@SendTo` was only detected on the concrete listener method.

Use `AnnotatedElementUtils.findMergedAnnotation()` instead.

**cherry-pick to 2.9.x, 2.8.x**
artembilan pushed a commit that referenced this issue Jun 14, 2022
@garyrussell @artembilan
GH-2304: Fix SendTo on Interface Etc.
a5a28cc 
Resolves #2304

`@SendTo` was only detected on the concrete listener method.

Use `AnnotatedElementUtils.findMergedAnnotation()` instead.

**cherry-pick to 2.9.x, 2.8.x**
artembilan pushed a commit that referenced this issue Jun 14, 2022
@garyrussell @artembilan
GH-2304: Fix SendTo on Interface Etc.
62ecbf0 
Resolves #2304

`@SendTo` was only detected on the concrete listener method.

Use `AnnotatedElementUtils.findMergedAnnotation()` instead.

**cherry-pick to 2.9.x, 2.8.x**
artembilan pushed a commit that referenced this issue Jun 14, 2022
@garyrussell @artembilan
GH-2304: Fix SendTo on Interface Etc.
273416c 
Resolves #2304

`@SendTo` was only detected on the concrete listener method.

Use `AnnotatedElementUtils.findMergedAnnotation()` instead.

**cherry-pick to 2.9.x, 2.8.x**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
backport 2.8.x (obsolete) backport 2.9.x (obsolete) type: enhancement
Projects
None yet
Milestone
3.0.0-M5
Development

Successfully merging a pull request may close this issue.

GH-2304: Fix SendTo on Interface Etc. garyrussell/spring-kafka
2 participants
@garyrussell @VovkaSOL