Skip to content

Fix interceptBeforeTx #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyrussell opened this issue Jul 6, 2022 · 0 comments · Fixed by #2330
Closed

Fix interceptBeforeTx #2329

garyrussell opened this issue Jul 6, 2022 · 0 comments · Fixed by #2330
Assignees
@garyrussell
Labels
backport 2.9.x (obsolete) type: bug
Milestone
3.0.0-M5

Comments

@garyrussell
Copy link
Contributor

Currently, this flag only works (when set to false) with a KafkaAwareTransactionManager; it should apply to any PlatformTransactionManager.
@garyrussell garyrussell added this to the 3.0.0.M5 milestone Jul 6, 2022
@garyrussell garyrussell self-assigned this Jul 6, 2022
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 6, 2022
@garyrussell
spring-projectsGH-2329: Fix interceptBeforeTx for Non-Kafka TM
bb99ec0 
Resolves spring-projects#2329

The flag should apply, regardless of PTM type.
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 6, 2022
@garyrussell
spring-projectsGH-2329: Fix interceptBeforeTx for Non-Kafka TM
a37f684 
Resolves spring-projects#2329

The flag should apply, regardless of PTM type.
@garyrussell garyrussell mentioned this issue Jul 6, 2022
Merged
artembilan pushed a commit that referenced this issue Jul 6, 2022
@garyrussell @artembilan
GH-2329: Fix interceptBeforeTx for Non-Kafka TM
1eca673 
Resolves #2329

The flag should apply, regardless of PTM type.
artembilan pushed a commit that referenced this issue Jul 6, 2022
@garyrussell @artembilan
GH-2329: Fix interceptBeforeTx for Non-Kafka TM
21172de 
Resolves #2329

The flag should apply, regardless of PTM type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
backport 2.9.x (obsolete) type: bug
Projects
None yet
Milestone
3.0.0-M5
Development

Successfully merging a pull request may close this issue.

GH-2329: Fix interceptBeforeTx for Non-Kafka TM garyrussell/spring-kafka
1 participant
@garyrussell