Skip to content

Container pause() Does Not Work with Manual TopicPartition Assignment #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyrussell opened this issue Jul 6, 2022 · 0 comments · Fixed by #2333
Closed

Container pause() Does Not Work with Manual TopicPartition Assignment #2332

garyrussell opened this issue Jul 6, 2022 · 0 comments · Fixed by #2333
Assignees
@garyrussell
Labels
backport 2.8.x (obsolete) backport 2.9.x (obsolete) type: bug
Milestone
3.0.0-M5

Comments

@garyrussell
Copy link
Contributor

No description provided.

@garyrussell garyrussell added this to the 3.0.0.M5 milestone Jul 6, 2022
@garyrussell garyrussell self-assigned this Jul 6, 2022
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 6, 2022
@garyrussell
spring-projectsGH-2332: Fix Container.pause() with Manual Assign.
5644256 
Resolves spring-projects#2332

Use manual assignments, if present for pause.
Also, in the rebalance listener, use `isPaused()` rather than `consumerPaused`
to determine whether the partitions should be paused.

Add logs and events for pauses in the rebal listener.

**cherry-pick to 2.9.x, 2.8.x**
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 6, 2022
@garyrussell
spring-projectsGH-2332: Fix Container.pause() with Manual Assign.
b6901c7 
Resolves spring-projects#2332

Use manual assignments, if present, for pause.
Also, in the rebalance listener, use `isPaused()` rather than `consumerPaused`
to determine whether the partitions should be paused.

Add logs and events for pauses in the rebal listener.

Revert errant log4j commit.

**cherry-pick to 2.9.x, 2.8.x**
@garyrussell garyrussell mentioned this issue Jul 6, 2022
Merged
artembilan pushed a commit that referenced this issue Jul 6, 2022
@garyrussell
GH-2332: Fix Container.pause() with Manual Assign.
c0e210c 
Resolves #2332

Use manual assignments, if present, for pause.
Also, in the rebalance listener, use `isPaused()` rather than `consumerPaused`
to determine whether the partitions should be paused.

Add logs and events for pauses in the rebal listener.

Revert errant log4j commit.

**cherry-pick to 2.9.x, 2.8.x**

* Use `CollectionUtils.isEmpty()`
artembilan pushed a commit that referenced this issue Jul 6, 2022
@garyrussell @artembilan
GH-2332: Fix Container.pause() with Manual Assign.
1f5ae61 
Resolves #2332

Use manual assignments, if present, for pause.
Also, in the rebalance listener, use `isPaused()` rather than `consumerPaused`
to determine whether the partitions should be paused.

Add logs and events for pauses in the rebal listener.

Revert errant log4j commit.

**cherry-pick to 2.9.x, 2.8.x**

* Use `CollectionUtils.isEmpty()`
garyrussell added a commit that referenced this issue Jul 7, 2022
@garyrussell
GH-2332: Fix Container.pause() with Manual Assign.
989fb29 
Resolves #2332

Use manual assignments, if present, for pause.
Also, in the rebalance listener, use `isPaused()` rather than `consumerPaused`
to determine whether the partitions should be paused.

Add logs and events for pauses in the rebal listener.

Revert errant log4j commit.

**cherry-pick to 2.9.x, 2.8.x**

* Use `CollectionUtils.isEmpty()`
garyrussell added a commit that referenced this issue Jul 7, 2022
@garyrussell
GH-2332: Fix Partitions in Pause Event
a63359c
garyrussell added a commit that referenced this issue Jul 7, 2022
@garyrussell
GH-2332: Fix Partitions in Pause Event
131b0e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
backport 2.8.x (obsolete) backport 2.9.x (obsolete) type: bug
Projects
None yet
Milestone
3.0.0-M5
Development

Successfully merging a pull request may close this issue.

GH-2332: Fix Container.pause() with Manual Assign. garyrussell/spring-kafka
1 participant
@garyrussell