Skip to content

Unable to modify Correlation ID header name in AggregatingReplyingKafkaTemplate #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hawkeye310 opened this issue Jul 12, 2022 · 0 comments · Fixed by #2347
Closed

Unable to modify Correlation ID header name in AggregatingReplyingKafkaTemplate #2344

hawkeye310 opened this issue Jul 12, 2022 · 0 comments · Fixed by #2347
Labels
backport 2.8.x (obsolete) backport 2.9.x (obsolete) type: bug
Milestone
3.0.0-M5

Comments

@hawkeye310
Copy link

In what version(s) of Spring for Apache Kafka are you seeing this issue?

2.8.2

Describe the bug

In AggregatingReplyingKafkaTemplate there is no provision to override the correlation ID header name which makes using custom names not possible.

To Reproduce
N/A

Expected behavior

Providing a custom name should be possible for the correlation header name when using AggregatingReplyingKafkaTemplate.
The behavior should be the same as the ReplyingKafkaTemplate.

Sample

A link to a GitHub repository with a minimal, reproducible, sample.

Reports that include a sample will take priority over reports that do not.
At times, we may require a sample, so it is good to try and include a sample up front.
@garyrussell garyrussell added this to the 3.0.0-M5 milestone Jul 12, 2022
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 12, 2022
@garyrussell
spring-projectsGH-2344: AggReplyingKT Support Custom Correlation
0faca7e 
Resolves spring-projects#2344

The `ReplyingKafkaTemplate` supports the use of a custom header name
for correlation, but the subclass `AggregatingReplyingKafkaTemplate`
was hard coded to use the default header.

Support the use of a custom header name in the subclass.

**cherry-pick to 2.9.x, 2.8.x**
@garyrussell garyrussell mentioned this issue Jul 12, 2022
Merged
artembilan pushed a commit that referenced this issue Jul 12, 2022
@garyrussell @artembilan
GH-2344: AggReplyingKT Support Custom Correlation
58b6889 
Resolves #2344

The `ReplyingKafkaTemplate` supports the use of a custom header name
for correlation, but the subclass `AggregatingReplyingKafkaTemplate`
was hard coded to use the default header.

Support the use of a custom header name in the subclass.

**cherry-pick to 2.9.x, 2.8.x**
artembilan pushed a commit that referenced this issue Jul 12, 2022
@garyrussell @artembilan
GH-2344: AggReplyingKT Support Custom Correlation
2732303 
Resolves #2344

The `ReplyingKafkaTemplate` supports the use of a custom header name
for correlation, but the subclass `AggregatingReplyingKafkaTemplate`
was hard coded to use the default header.

Support the use of a custom header name in the subclass.

**cherry-pick to 2.9.x, 2.8.x**
artembilan pushed a commit that referenced this issue Jul 12, 2022
@garyrussell @artembilan
GH-2344: AggReplyingKT Support Custom Correlation
f1f200c 
Resolves #2344

The `ReplyingKafkaTemplate` supports the use of a custom header name
for correlation, but the subclass `AggregatingReplyingKafkaTemplate`
was hard coded to use the default header.

Support the use of a custom header name in the subclass.

**cherry-pick to 2.9.x, 2.8.x**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backport 2.8.x (obsolete) backport 2.9.x (obsolete) type: bug
Projects
None yet
Milestone
3.0.0-M5
Development

Successfully merging a pull request may close this issue.

GH-2344: AggReplyingKT Support Custom Correlation garyrussell/spring-kafka
2 participants
@garyrussell @hawkeye310