Skip to content

Do Not Update Partition Pausing Field In CMLC #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyrussell opened this issue Jul 13, 2022 · 0 comments · Fixed by #2353
Closed

Do Not Update Partition Pausing Field In CMLC #2350

garyrussell opened this issue Jul 13, 2022 · 0 comments · Fixed by #2353
Labels
backport 2.8.x (obsolete) backport 2.9.x (obsolete) type: bug

Comments

@garyrussell
Copy link
Contributor

#2222 (comment)

Fields for paused partitions are only used in the KMLC but they also exist in the CMLC and can get out of whack after a rebalance, causing confusion.

Remove the fields from the AMLC.
@garyrussell garyrussell changed the title Remove Partition Pausing Fields From AMLC Do Not Update Partition Pausing Field In CMLC Jul 13, 2022
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 13, 2022
@garyrussell
spring-projectsGH-2350: Fix Paused Partions After Rebalance
687e787 
Resolves spring-projects#2350

Do not maintain the `pausePartitionsRequested` field in the concurrent MLC,
it is not used and can cause confusion.

Also resolves spring-projects#2222

The previous fix removed revoked partitions from `pausePartitionsRequested`;
this was incorrect - consider a rebalance where we lose `topic-0` and another
rebalance where we are re-assigned `topic-0`. According to the contract, this
partition should remain paused.

**cherry-pick to 2.9.x, 2.8.x**
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 13, 2022
@garyrussell
spring-projectsGH-2350: Fix Paused Partitions After Rebalance
4dfc334 
Resolves spring-projects#2350

Do not maintain the `pausePartitionsRequested` field in the concurrent MLC,
it is not used and can cause confusion.

Also resolves spring-projects#2222

The previous fix removed revoked partitions from `pausePartitionsRequested`;
this was incorrect - consider a rebalance where we lose `topic-0` and another
rebalance where we are re-assigned `topic-0`. According to the contract, this
partition should remain paused.

**cherry-pick to 2.9.x, 2.8.x**
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 13, 2022
@garyrussell
spring-projectsGH-2350: Fix Paused Partitions After Rebalance
f84e235 
Resolves spring-projects#2350

Do not maintain the `pausePartitionsRequested` field in the concurrent MLC,
it is not used and can cause confusion.

Also fixes some synchronization around `CMLC.containers`.

Also resolves spring-projects#2222

The previous fix removed revoked partitions from `pausePartitionsRequested`;
this was incorrect - consider a rebalance where we lose `topic-0` and another
rebalance where we are re-assigned `topic-0`. According to the contract, this
partition should remain paused.

**cherry-pick to 2.9.x, 2.8.x**
@garyrussell garyrussell mentioned this issue Jul 13, 2022
Merged
artembilan pushed a commit that referenced this issue Jul 13, 2022
@garyrussell @artembilan
GH-2350: Fix Paused Partitions After Rebalance
4aa5c2a 
Resolves #2350

Do not maintain the `pausePartitionsRequested` field in the concurrent MLC,
it is not used and can cause confusion.

Also fixes some synchronization around `CMLC.containers`.

Also resolves #2222

The previous fix removed revoked partitions from `pausePartitionsRequested`;
this was incorrect - consider a rebalance where we lose `topic-0` and another
rebalance where we are re-assigned `topic-0`. According to the contract, this
partition should remain paused.

**cherry-pick to 2.9.x, 2.8.x**
artembilan pushed a commit that referenced this issue Jul 13, 2022
@garyrussell @artembilan
GH-2350: Fix Paused Partitions After Rebalance
e682c87 
Resolves #2350

Do not maintain the `pausePartitionsRequested` field in the concurrent MLC,
it is not used and can cause confusion.

Also fixes some synchronization around `CMLC.containers`.

Also resolves #2222

The previous fix removed revoked partitions from `pausePartitionsRequested`;
this was incorrect - consider a rebalance where we lose `topic-0` and another
rebalance where we are re-assigned `topic-0`. According to the contract, this
partition should remain paused.

**cherry-pick to 2.9.x, 2.8.x**
artembilan pushed a commit that referenced this issue Jul 13, 2022
@garyrussell @artembilan
GH-2350: Fix Paused Partitions After Rebalance
e94985b 
Resolves #2350

Do not maintain the `pausePartitionsRequested` field in the concurrent MLC,
it is not used and can cause confusion.

Also fixes some synchronization around `CMLC.containers`.

Also resolves #2222

The previous fix removed revoked partitions from `pausePartitionsRequested`;
this was incorrect - consider a rebalance where we lose `topic-0` and another
rebalance where we are re-assigned `topic-0`. According to the contract, this
partition should remain paused.

**cherry-pick to 2.9.x, 2.8.x**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backport 2.8.x (obsolete) backport 2.9.x (obsolete) type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-2350: Fix Paused Partitions After Rebalance garyrussell/spring-kafka
1 participant
@garyrussell